From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754003AbbHXIRa (ORCPT ); Mon, 24 Aug 2015 04:17:30 -0400 Received: from mailout1.w1.samsung.com ([210.118.77.11]:17004 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751980AbbHXIR2 (ORCPT ); Mon, 24 Aug 2015 04:17:28 -0400 X-AuditID: cbfec7f5-f794b6d000001495-50-55dad31575af Message-id: <55DAD314.1030802@samsung.com> Date: Mon, 24 Aug 2015 10:17:24 +0200 From: Jacek Anaszewski User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130804 Thunderbird/17.0.8 MIME-version: 1.0 To: Vaishali Thakkar Cc: Bryan Wu , linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] leds: leds-fsg: Use devm_led_classdev_register References: <20150818142016.GA2549@localhost> In-reply-to: <20150818142016.GA2549@localhost> Content-type: text/plain; charset=ISO-8859-1; format=flowed Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrLLMWRmVeSWpSXmKPExsVy+t/xa7qil2+FGpx/qGBxdOdEJovLu+aw WWx9s47R4vnKa6wOLB47Z91l9/i8SS6AKYrLJiU1J7MstUjfLoEr4+HvJ+wFC1kr3u/YxNLA uIqli5GTQ0LARGLnvKVsELaYxIV764FsLg4hgaWMEjdX7GaEcJ4xSrxZ28cEUsUroCWxYVML mM0ioCrx+/4mRhCbTcBQ4ueL12BxUYEIiT+n97FC1AtK/Jh8D2ybiICuxNeJP8G2MQvESvw6 twasXljATWL2qiVANRxAy3Qlfv0pAwlzCuhJdC86xAJRbi2xctI2RghbXmLzmrfMExgFZiHZ MAtJ2SwkZQsYmVcxiqaWJhcUJ6XnGukVJ+YWl+al6yXn525ihATq1x2MS49ZHWIU4GBU4uFd YXYrVIg1say4MvcQowQHs5IIr9LLm6FCvCmJlVWpRfnxRaU5qcWHGKU5WJTEeWfueh8iJJCe WJKanZpakFoEk2Xi4JRqYHTIm2l6xI0n2OP97tynGpXb9s16vGoJh+A5Rf0pjVz7DfQ7TOUn RC1ja4+o3JVgu+axv8DvtZU6ap5PHktXXQ2MflJ7fPXmuD+3pPc6tp7j9P+4ovjO7pZ3J7hk g7+8kdi+la3mXzNvBxtTSeNazZcSXGpnVDL5g/RflnX76J5YwG2Tl7k8UYmlOCPRUIu5qDgR AElgy3BQAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/18/2015 04:20 PM, Vaishali Thakkar wrote: > Use resource-managed function devm_led_classdev_register instead > of led_classdev_register to make the error-path simpler. > > To be compatible with the change, various gotos are replced with > direct returns and unneeded labels are dropped. Also, remove > fsg_led_remove as it is now redundant. > > Signed-off-by: Vaishali Thakkar > --- > Changes since v1: > - Fix build errors > --- > drivers/leds/leds-fsg.c | 52 ++++++++++++------------------------------------- > 1 file changed, 12 insertions(+), 40 deletions(-) Merged, thanks. -- Best Regards, Jacek Anaszewski