Re: [PATCH 1/7] phy: exynos-usb2: add vbus regulator support

Marek Szyprowski
2015-08-25T05:47:36Z

Hello,

On 2015-08-21 14:44, Kishon Vijay Abraham I wrote:
> On Friday 21 August 2015 06:08 PM, Marek Szyprowski wrote:
>> Exynos USB2 PHY has separate power supply, which is usually provided by
>> VBUS regulator. This patch adds support for it. VBUS regulator is
>> optional, to keep compatibility with boards, which have VBUS provided
>> from some always-on power source.
>>
>> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
>> ---
>> .../devicetree/bindings/phy/samsung-phy.txt | 3 +++
>> drivers/phy/phy-samsung-usb2.c | 25 ++++++++++++++++++++--
>> drivers/phy/phy-samsung-usb2.h | 2 ++
>> 3 files changed, 28 insertions(+), 2 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/phy/samsung-phy.txt b/Documentation/devicetree/bindings/phy/samsung-phy.txt
>> index 60c6f2a633e0..0289d3b07853 100644
>> --- a/Documentation/devicetree/bindings/phy/samsung-phy.txt
>> +++ b/Documentation/devicetree/bindings/phy/samsung-phy.txt
>> @@ -44,6 +44,9 @@ Required properties:
>> - the "ref" clock is used to get the rate of the clock provided to the
>> PHY module
>>
>> +Optional properties:
>> +- vbus-supply: power-supply phandle for vbus power source
> how about using phy-supply?

I wanted to make it a bit more descriptive (vbus-supply is rather self
explaining name)
and keep it in line with Exynos usb3-drd phy, which already supports
vbus-supply.
If you think that this is a bad idea, a will use phy-supply then.

Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland