From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755283AbbHYL7x (ORCPT ); Tue, 25 Aug 2015 07:59:53 -0400 Received: from mail-oi0-f51.google.com ([209.85.218.51]:34134 "EHLO mail-oi0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754002AbbHYL7v (ORCPT ); Tue, 25 Aug 2015 07:59:51 -0400 Message-ID: <55DC58B5.1070001@acm.org> Date: Tue, 25 Aug 2015 06:59:49 -0500 From: Corey Minyard Reply-To: minyard@acm.org User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: yalin wang CC: Brijesh Singh , openipmi-developer@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ipmi: add of_device_id in MODULE_DEVICE_TABLE References: <1440425725-8445-1-git-send-email-brijeshkumar.singh@amd.com> <55DBBB6C.3010801@acm.org> <19EBCACB-31F4-4559-A8A1-7ABD67DD8D22@gmail.com> In-Reply-To: <19EBCACB-31F4-4559-A8A1-7ABD67DD8D22@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/24/2015 09:04 PM, yalin wang wrote: >> On Aug 25, 2015, at 08:48, Corey Minyard wrote: >> >> Well, I should have compile tested first. On x86_64: >> >> >> CC [M] drivers/char/ipmi/ipmi_si_intf.o >> In file included from ../drivers/char/ipmi/ipmi_si_intf.c:42:0: >> ../drivers/char/ipmi/ipmi_si_intf.c:2804:25: error: ‘ipmi_match’ >> undeclared here (not in a function) >> MODULE_DEVICE_TABLE(of, ipmi_match); >> ^ >> ../include/linux/module.h:223:21: note: in definition of macro >> ‘MODULE_DEVICE_TABLE’ >> extern const typeof(name) __mod_##type##__##name##_device_table \ >> ^ >> ../include/linux/module.h:223:27: error: >> ‘__mod_of__ipmi_match_device_table’ aliased to undefined symbol ‘ipmi_match’ >> extern const typeof(name) __mod_##type##__##name##_device_table \ >> ^ >> ../drivers/char/ipmi/ipmi_si_intf.c:2804:1: note: in expansion of macro >> ‘MODULE_DEVICE_TABLE’ >> MODULE_DEVICE_TABLE(of, ipmi_match); >> >> >> This has to compile on all arches. I'm not sure what is wrong, but I've >> removed the patch. >> >> -corey > it seems should be : > > MODULE_DEVICE_TABLE(of, of_ipmi_match); I actually already tried that, and it fails to compile on x86_64, too, with a different error. -corey