From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756222AbbHYVuB (ORCPT ); Tue, 25 Aug 2015 17:50:01 -0400 Received: from mail-lb0-f178.google.com ([209.85.217.178]:36305 "EHLO mail-lb0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755822AbbHYVt7 (ORCPT ); Tue, 25 Aug 2015 17:49:59 -0400 Subject: Re: [PATCH v2] mmc: host: use of_property_read_bool() To: Ulf Hansson References: <3376063.1JTtbbjJ3D@wasted.cogentembedded.com> <55DC98A7.5000202@cogentembedded.com> Cc: linux-mmc , "linux-kernel@vger.kernel.org" From: Sergei Shtylyov Organization: Cogent Embedded Message-ID: <55DCE304.7020001@cogentembedded.com> Date: Wed, 26 Aug 2015 00:49:56 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/26/2015 12:19 AM, Ulf Hansson wrote: >>>> Use more compact of_property_read_bool() calls instead of the >>>> of_find_property() >>>> calls. >>>> Signed-off-by: Sergei Shtylyov >> >>> Thanks, applied for next! >> >> Thanks to you! :-) >> >>> Next, time please run checkpatch to remove errors/warnings. >> >> Hum, I just did and the patch seems clean: >> >> [headless@wasted mmc]$ scripts/checkpatch.pl >> patches/mmc-host-use-of_property_read_bool.patch >> total: 0 errors, 0 warnings, 81 lines checked >> >> patches/mmc-host-use-of_property_read_bool.patch has no obvious style >> problems and is ready for submission. >> >> What do you mean? > WARNING: Possible unwrapped commit description (prefer a maximum 75 > chars per line) > #12: > Use more compact of_property_read_bool() calls instead of the of_find_property() > total: 0 errors, 1 warnings, 81 lines checked > I suspect we might use different versions of the checkpatch script. > Mine is from 4.2rc7. Tried several variants, the last one was in your repo's 'next' branch (4.2-rc7 based). No warning. :-) > No worries then! > Kind regards > Uffe MBR, Sergei