From: "Noralf Trønnes" <noralf@tronnes.org>
To: Stefan Wahren <stefan.wahren@i2se.com>,
Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Henri Chain <henri.chain@eleves.ec-nantes.fr>,
linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org
Subject: Re: [PATCH 1/2] staging: fbtft: fix 9-bit SPI support detection
Date: Wed, 26 Aug 2015 00:07:00 +0200 [thread overview]
Message-ID: <55DCE704.1060000@tronnes.org> (raw)
In-Reply-To: <1440536652-7940-2-git-send-email-stefan.wahren@i2se.com>
Den 25.08.2015 23:04, skrev Stefan Wahren:
> Since the result of the setup function isn't adequate to check
> 9-bit SPI support, we better check bits_per_word_mask. Btw this
> change avoids a NULL pointer dereference with master drivers
> without a separate setup function.
>
> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
> ---
> drivers/staging/fbtft/fbtft-core.c | 10 +++-------
> drivers/staging/fbtft/flexfb.c | 11 ++++-------
> 2 files changed, 7 insertions(+), 14 deletions(-)
Thanks Stefan.
Both patches:
Acked-by: Noralf Trønnes <noralf@tronnes.org>
next prev parent reply other threads:[~2015-08-25 22:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-25 21:04 [PATCH 0/2] staging: fbtft: Avoid calling SPI master setup directly Stefan Wahren
2015-08-25 21:04 ` [PATCH 1/2] staging: fbtft: fix 9-bit SPI support detection Stefan Wahren
2015-08-25 22:07 ` Noralf Trønnes [this message]
2015-08-25 21:04 ` [PATCH 2/2] staging: fbtft: replace master->setup() with spi_setup() Stefan Wahren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55DCE704.1060000@tronnes.org \
--to=noralf@tronnes.org \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=henri.chain@eleves.ec-nantes.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=stefan.wahren@i2se.com \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox