From: Stas Sergeev <stsp@list.ru>
To: madalin.bucur@freescale.com, f.fainelli@gmail.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Igal.Liberman@freescale.com
Subject: Re: [v2] net: phy: fixed: propagate fixed link values to struct
Date: Wed, 26 Aug 2015 18:51:21 +0300 [thread overview]
Message-ID: <55DDE079.7070401@list.ru> (raw)
In-Reply-To: <1440601127-7663-1-git-send-email-madalin.bucur@freescale.com>
26.08.2015 17:58, Madalin Bucur пишет:
> The fixed link values parsed from the device tree are stored in
> the struct fixed_phy member status. The struct phy_device members
> speed, duplex were not updated.
ACK, but IMHO it will make more sense if you include that
into your upcoming patch set rather than sending separately,
as otherwise there is simply no in-kernel users of that new
functionality (all the current users likely do not access
these fields as early as you want to, so they don't care).
In any case, the patch looks good to me and the policy is
up to others.
next prev parent reply other threads:[~2015-08-26 15:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-26 14:58 [v2] net: phy: fixed: propagate fixed link values to struct Madalin Bucur
2015-08-26 15:51 ` Stas Sergeev [this message]
2015-08-26 16:12 ` Madalin-Cristian Bucur
2015-08-26 18:48 ` Florian Fainelli
2015-08-27 18:25 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55DDE079.7070401@list.ru \
--to=stsp@list.ru \
--cc=Igal.Liberman@freescale.com \
--cc=f.fainelli@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=madalin.bucur@freescale.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox