From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756130AbbHZPvZ (ORCPT ); Wed, 26 Aug 2015 11:51:25 -0400 Received: from smtp28.mail.ru ([94.100.181.183]:50928 "EHLO smtp28.mail.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751859AbbHZPvY (ORCPT ); Wed, 26 Aug 2015 11:51:24 -0400 Message-ID: <55DDE079.7070401@list.ru> Date: Wed, 26 Aug 2015 18:51:21 +0300 From: Stas Sergeev User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: madalin.bucur@freescale.com, f.fainelli@gmail.com CC: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Igal.Liberman@freescale.com Subject: Re: [v2] net: phy: fixed: propagate fixed link values to struct References: <1440601127-7663-1-git-send-email-madalin.bucur@freescale.com> In-Reply-To: <1440601127-7663-1-git-send-email-madalin.bucur@freescale.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Mras: Ok Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 26.08.2015 17:58, Madalin Bucur пишет: > The fixed link values parsed from the device tree are stored in > the struct fixed_phy member status. The struct phy_device members > speed, duplex were not updated. ACK, but IMHO it will make more sense if you include that into your upcoming patch set rather than sending separately, as otherwise there is simply no in-kernel users of that new functionality (all the current users likely do not access these fields as early as you want to, so they don't care). In any case, the patch looks good to me and the policy is up to others.