From: Hideaki Kimura <hideaki.kimura@hpe.com>
To: Jason Low <jason.low2@hp.com>, Oleg Nesterov <oleg@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
linux-kernel@vger.kernel.org,
Frederic Weisbecker <fweisbec@gmail.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Steven Rostedt <rostedt@goodmis.org>,
Rik van Riel <riel@redhat.com>,
Scott J Norton <scott.norton@hp.com>
Subject: Re: [PATCH 0/3] timer: Improve itimers scalability
Date: Wed, 26 Aug 2015 15:53:26 -0700 [thread overview]
Message-ID: <55DE4366.9080104@hpe.com> (raw)
In-Reply-To: <1440626847.23728.122.camel@j-VirtualBox>
Sure, let me elaborate.
Executive summary:
Yes, enabling a process-wide timer in such a large machine is not
wise, but sometimes users/applications cannot avoid it.
The issue was observed actually not in a database itself but in a common
library it links to; gperftools.
The database itself is optimized for many-cores/sockets, so surely it
avoids putting a process-wide timer or other unscalable things. It just
links to libprofiler for an optional feature to profile performance
bottleneck only when the user turns it on. We of course avoid turning
the feature on unless while we debug/tune the database.
However, libprofiler sets the timer even when the client program doesn't
invoke any of its functions: libprofiler does it when the shared library
is loaded. We requested the developer of libprofiler to change the
behavior, but seems like there is a reason to keep that behavior:
https://code.google.com/p/gperftools/issues/detail?id=133
Based on this, I think there are two reasons why we should ameliorate
this issue in kernel layer.
1. In the particular case, it's hard to prevent or even detect the issue
in user space.
We (a team of low-level database and kernel experts) in fact spent huge
amount of time to just figure out what's the bottleneck there because
nothing measurable happens in user space. I pulled out countless hairs.
Also, the user has to de-link the library from the application to
prevent the itimer installation. Imagine a case where the software is
proprietary. It won't fly.
2. This is just one example. There could be many other such
binaries/libraries that do similar things somewhere in a complex
software stack.
Today we haven't heard of many such cases, but people will start hitting
it once 100s~1,000s of cores become common.
After applying this patchset, we have observed that the performance hit
almost completely went away at least for 240 cores. So, it's quite
beneficial in real world.
--
Hideaki Kimura
next prev parent reply other threads:[~2015-08-26 23:10 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-26 3:17 [PATCH 0/3] timer: Improve itimers scalability Jason Low
2015-08-26 3:17 ` [PATCH 1/3] timer: Optimize fastpath_timer_check() Jason Low
2015-08-26 21:57 ` Frederic Weisbecker
2015-08-31 15:15 ` Davidlohr Bueso
2015-08-31 19:40 ` Jason Low
2015-08-26 3:17 ` [PATCH 2/3] timer: Check thread timers only when there are active thread timers Jason Low
2015-08-26 3:17 ` [PATCH 3/3] timer: Reduce unnecessary sighand lock contention Jason Low
2015-08-26 17:53 ` Linus Torvalds
2015-08-26 22:31 ` Frederic Weisbecker
2015-08-26 22:57 ` Jason Low
2015-08-26 22:56 ` Frederic Weisbecker
2015-08-26 23:32 ` Jason Low
2015-08-27 4:52 ` Jason Low
2015-08-27 12:53 ` Frederic Weisbecker
2015-08-27 20:29 ` Jason Low
2015-08-27 21:12 ` Frederic Weisbecker
2015-08-26 3:27 ` [PATCH 0/3] timer: Improve itimers scalability Andrew Morton
2015-08-26 16:33 ` Jason Low
2015-08-26 17:08 ` Oleg Nesterov
2015-08-26 22:07 ` Jason Low
2015-08-26 22:53 ` Hideaki Kimura [this message]
2015-08-26 23:13 ` Frederic Weisbecker
2015-08-26 23:45 ` Hideaki Kimura
2015-08-27 13:18 ` Frederic Weisbecker
2015-08-27 14:47 ` Steven Rostedt
2015-08-27 15:09 ` Thomas Gleixner
2015-08-27 15:17 ` Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55DE4366.9080104@hpe.com \
--to=hideaki.kimura@hpe.com \
--cc=akpm@linux-foundation.org \
--cc=fweisbec@gmail.com \
--cc=jason.low2@hp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=oleg@redhat.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=riel@redhat.com \
--cc=rostedt@goodmis.org \
--cc=scott.norton@hp.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox