From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752065AbbH0H07 (ORCPT ); Thu, 27 Aug 2015 03:26:59 -0400 Received: from mailout3.w1.samsung.com ([210.118.77.13]:64624 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750725AbbH0H05 (ORCPT ); Thu, 27 Aug 2015 03:26:57 -0400 X-AuditID: cbfec7f4-f79c56d0000012ee-27-55debbbe3a64 Message-id: <55DEBBBD.9010802@samsung.com> Date: Thu, 27 Aug 2015 09:26:53 +0200 From: Jacek Anaszewski User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130804 Thunderbird/17.0.8 MIME-version: 1.0 To: Vaishali Thakkar Cc: Richard Purdie , linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] leds: leds-cobalt-qube: Use devm_led_classdev_register References: <20150827051302.GA10275@localhost> In-reply-to: <20150827051302.GA10275@localhost> Content-type: text/plain; charset=ISO-8859-1; format=flowed Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrELMWRmVeSWpSXmKPExsVy+t/xy7r7dt8LNTi9WM7i8q45bBZb36xj tNi96ymrxfOV11gdWDx2zrrL7rFn/g9Wj8+b5AKYo7hsUlJzMstSi/TtErgyzi7dx1iwlq9i 199GlgbGc9xdjJwcEgImEn8a5rBC2GISF+6tZ+ti5OIQEljKKLFo9S9WCOcZo8SEphlsIFW8 AloS96dMYOpi5OBgEVCV6HjAAxJmEzCU+PniNROILSoQIfHn9D5WiHJBiR+T77GA2CICuhJf J/4EG8MskCTx+OsRRhBbWMBb4tbSz2D1QgJ6ElMP3QWzOQX0Jab8280IUW8tsXLSNihbXmLz mrfMExgFZiFZMQtJ2SwkZQsYmVcxiqaWJhcUJ6XnGuoVJ+YWl+al6yXn525ihITslx2Mi49Z HWIU4GBU4uGVyLgXKsSaWFZcmXuIUYKDWUmE1z8fKMSbklhZlVqUH19UmpNafIhRmoNFSZx3 7q73IUIC6YklqdmpqQWpRTBZJg5OqQbGeaczfUvex61cqhmk8EMgTL3+YPwJsZSs8wbzHae3 96rMeXYw/Jq3QVgn/4aDN0/d/VfCwxgo7/bh19YblrdiT0uHzVtT73I64rJArL0x7/5XqSKH 5jzTc1ixzYstZe+9vdnTr30NvLN7bvDbp3qmbiy7tSpFU5gUth4Kn+b7ODem78/Dhpf/lViK MxINtZiLihMBy2Sho1UCAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Vaishali, Thanks for the patch. On 08/27/2015 07:13 AM, Vaishali Thakkar wrote: > Use resource-managed function devm_led_classdev_register instead > of led_classdev_register to make the error-path simpler. > > To be compatible with the change, goto is replaced with direct > return and unneeded label is dropped. Also, remove redundant > cobalt_qube_led_remove. > > Signed-off-by: Vaishali Thakkar > --- > drivers/leds/leds-cobalt-qube.c | 20 ++------------------ > 1 file changed, 2 insertions(+), 18 deletions(-) > > diff --git a/drivers/leds/leds-cobalt-qube.c b/drivers/leds/leds-cobalt-qube.c > index d975220..59818df 100644 > --- a/drivers/leds/leds-cobalt-qube.c > +++ b/drivers/leds/leds-cobalt-qube.c > @@ -49,31 +49,15 @@ static int cobalt_qube_led_probe(struct platform_device *pdev) > led_value = LED_FRONT_LEFT | LED_FRONT_RIGHT; > writeb(led_value, led_port); > > - retval = led_classdev_register(&pdev->dev, &qube_front_led); > + retval = devm_led_classdev_register(&pdev->dev, &qube_front_led); > if (retval) > - goto err_null; We can spare more lines by changing this to: return devm_led_classdev_register(&pdev->dev, &qube_front_led); You could get rid of retval then, too. > - > - return 0; > - > -err_null: > - led_port = NULL; > - > - return retval; > -} > - > -static int cobalt_qube_led_remove(struct platform_device *pdev) > -{ > - led_classdev_unregister(&qube_front_led); > - > - if (led_port) > - led_port = NULL; > + return retval; > > return 0; > } > > static struct platform_driver cobalt_qube_led_driver = { > .probe = cobalt_qube_led_probe, > - .remove = cobalt_qube_led_remove, > .driver = { > .name = "cobalt-qube-leds", > }, > -- Best Regards, Jacek Anaszewski