From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753027AbbH0LoQ (ORCPT ); Thu, 27 Aug 2015 07:44:16 -0400 Received: from mail-bn1on0058.outbound.protection.outlook.com ([157.56.110.58]:16112 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751471AbbH0LoO (ORCPT ); Thu, 27 Aug 2015 07:44:14 -0400 Authentication-Results: spf=pass (sender IP is 149.199.60.100) smtp.mailfrom=xilinx.com; linaro.org; dkim=none (message not signed) header.d=none;linaro.org; dmarc=bestguesspass action=none header.from=xilinx.com; Subject: Re: [PATCH] mmc: Kconfig: Add dependency on GPIOLIB for MMC_SDHCI To: Ulf Hansson , Michal Simek References: <6906e34b62f162018984a5fbd12b3ef6cd5e3a29.1438839562.git.michal.simek@xilinx.com> CC: "linux-kernel@vger.kernel.org" , "Michal Simek" , Scott Branden , Weijun Yang , Andrew Bresticker , "Jean Delvare" , Srinivas Kandagatla , linux-mmc , "Alim Akhtar" , addy ke , "Stephen Boyd" , Chaotian Jing , Kevin Hao , Vincent Yang From: Michal Simek X-Enigmail-Draft-Status: N1110 Message-ID: <55DEF7FD.8020904@xilinx.com> Date: Thu, 27 Aug 2015 13:43:57 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-RCIS-Action: ALLOW X-TM-AS-Product-Ver: IMSS-7.1.0.1224-8.0.0.1202-21774.005 X-TM-AS-User-Approved-Sender: Yes;Yes X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1;BN1BFFO11FD020;1:bN5Pf8viVNUQ/hQq3GgHKPdLeEPqWxuEmMXg/NTJ+wQZbjDZOK6m2yGkDDVVgx7gaSVL2aKQnbw3X6G09lDn677b/S1k7JggUeDQkBVRN9JFirkN5EPuAKXFUdtRCcPnDtxZEp2ZfU4TJkpClhCk9VUnjckf0M9+1u94aoDjH20A0wiS0CGBpDq4JDT0lYuqVAhMDFQB/dhKxfoIi3BzwmqZj3TvEMT2lmME6J4FcyEYILb0L/d4NkBk+on9udDK+m77IPoHTonpACScotCDkugXT3wLOphQul3G+ZE2xwuCkyuM8vOfRrAGzBJj3jN3ODTfPdP9F2kVCpcSyjiV6Q== X-Forefront-Antispam-Report: CIP:149.199.60.100;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(438002)(3050300001)(189002)(377454003)(199003)(164054003)(479174004)(24454002)(19580395003)(19580405001)(4001350100001)(80316001)(87266999)(54356999)(65816999)(59896002)(76176999)(23676002)(50466002)(47776003)(50986999)(64706001)(83506001)(6806004)(64126003)(65806001)(5007970100001)(65956001)(106466001)(46102003)(81156007)(4001540100001)(189998001)(5001770100001)(5001920100001)(5001860100001)(5001830100001)(36386004)(62966003)(77156002)(77096005)(92566002)(5001960100002)(2950100001)(4001450100002)(87936001)(33656002)(63266004)(575784001)(86362001)(36756003)(107986001)(5001870100001);DIR:OUT;SFP:1101;SCL:1;SRVR:BN1BFFO11HUB053;H:xsj-pvapsmtpgw02;FPR:;SPF:Pass;PTR:unknown-60-100.xilinx.com,xapps1.xilinx.com;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BN1BFFO11HUB053;2:nCjeon8xAvFbmAzlI5NdUzGxYHlGJGOksLzA/hLNkka2JLSrbgcQOYPBrcLSi1oDYtTUjhHMhXtVaHmoXkyLVrsljhM7/mqb9O6ioC7giv+6mpRczBIAoIzo53ChLsOXocQ8hyFDdYDFeHA0qLcC8WvF16y4mxJdklQQmirPIUs=;3:Y3lRVDADSw5uEIQL21AoApfn7r4K5tIR/qzwrObv7NBVrTxZ12EKSNBgDH/D002JAhrbnsIc1AZeVuUcLmPNOoMFnKXj4w4mw/glEM1ZOV2q8PfiV5sf/Tlj4SjGreGDqioIpQAgxGoKSSq+f7xAsT5n5v2Hc4CjkayLVVAChAuAGlWpCB6bXLOYj1sWZBbUNCORABlQIf0+WUZhHiT3GfylFY1n1GSv1SMiYPBBGVgzVhNlRG938xv+JHdKD8Lk3N/fSen83cUmvRkivgGgyA==;25:9r0G6AzLfBRnBcTF6vI3Av+1ne++5K9OOy/dUTd7mg9UN33J1OXfVN2rtEPRf7EkvFyzpCFlN5eWpQSFGrDJFSCFX5IvHfZzpCaXQv3T/l8g2AS/PE4nFiW0LI6iyob7b2aNiC+WzLdHKWgD1MDTod8StjDoUJyWWkD3QqCdBqC0qfwovzaPCuiYfKeM0WIlBTxkiDBjU17q/X25QrAzCBx33+qTRcn+KZGinxaZ4flYiaaoqJ+mXhiCH9zE3Iz0qwySzyXt0sV/0IVi+UIsfw== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(8251501001);SRVR:BN1BFFO11HUB053; X-Microsoft-Exchange-Diagnostics: 1;BN1BFFO11HUB053;20:/Co/kRsmQP8FXIdozEa0/HNEc8+HvSCXnJtHJkh/Vt5Aw85BJ0FGlo06xm4DVqXNOeNE0rlMHFV40610nVUlB63wLmM8wSfofl1jheVZ15FbOXy3ftUvlI1k02kbsDRBFhcHtXDTQQk0rd4fp9G9w4IxQwx5O2QMch0pcckHMYJ0MhHOikQgfHp9kJWofGVsBSDD1he8UExuK4vraa8wuqrUMwsCe3TWRvZKZ3Le9jysLjcr3xdqRT8BohKb3k3Y0CY387nnfjNVRVNn/ItKq2WYSvqZ2fviPfBmIECY75niSsbtwEMnHbSFe9+mGeAVF7Uve5XXj1vHqaIuPcQsbKco+C0b6N8h3KTy9tZuEPbH6y0CeEa2P1JhzqZuNY8TFXlFuQ+ANbJyOjaDdQWNmix4FH7lynxoxUuDX8NkCvAt0g5JSCExv2YFRsNgGj68gerP5GTksO3vj3U2pB6pKgBQXLZWtCdpEakvJ4UK8KQW9ZWQCJMqS3+fafwA4YnP;4:pEjhfLi67mEfxD2B0Ei62qsUotGJYec8GIHiVoZT+Y/9kyyaGmVSKpY0fAs1Hm6Ap7b/es/jDuYgGwWTStdh1+BLkrvsFxQY5eOq0bJ9Y3bPSx+FSIqLNP9oI2QSQzwK1llNCGT+gSUc632MOWGkxr8lMoY4Dd5Z2JXcYXN5HI4zkg6rHaLgnsZezexq2BMbDCagaSvYNtqOaqgKL5L9ujGq++QN4gIDTaQJDiPdFXv5+jslz11LIUmCXimh2hvyPmyXpNT9JwrTCGriK3q2QZPM4l+8wqWhqZGh7Uz/dLNadtsQ9ZwlsdGB4ZPV75AE X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(8121501046)(5005006)(3002001);SRVR:BN1BFFO11HUB053;BCL:0;PCL:0;RULEID:;SRVR:BN1BFFO11HUB053; X-Forefront-PRVS: 06818431B9 X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCTjFCRkZPMTFIVUIwNTM7MjM6RWxKRWZhdno3N3hYZlVGcmR3TCtJWkdr?= =?utf-8?B?Mko5OUZtUkcvVDl5cEZTYWhsNXZ1MmlqRGlxeUlsUlNCYU1LOUJCc210K1RY?= =?utf-8?B?c2xqWGdmRUs3UlR2SzM5OUVCZlUwT3l3Tk5OSlpuSGphbVB1cjd3TlFGWDY0?= =?utf-8?B?b2FEQjg0YVA3M0NaRzBCYnJjZW00S1NBcTJQRFpDN3BXZ0UvU0hLMEtseThu?= =?utf-8?B?VDVwUFVwSGJ1SHNBSFphNlFSNzc3QzBMd1V3b1JxQzhRS2Nwc3lVeUUySHNi?= =?utf-8?B?SUtKcUlhdmpNaTZMNHlTNGtJM2s2VnhnZ0M1blVjVGNOeUREM3dQcmJhL1VX?= =?utf-8?B?RUZVaTlKeDhRdUNzSTQ3RFB1ZE9RbW9CQk5Tb2pkTzltUGtYY0dBc3ZGMWpG?= =?utf-8?B?Z0gvVzBRMG5mcjR4d21ad1BtZGZJZnZZSWM1cGJtekJPYmdwN2dNeUZMbGJX?= =?utf-8?B?TEg2OHZMbG9hc2I0ZnlzdjBtTWxBM1NoY0dyNTZTUW56QUZrOHdnVU1INlYx?= =?utf-8?B?OGdCZU4xUk1lUEZCRENpUWhRNEdmN2piei9sSCs0dEUwZWd2VTVWTzZualRh?= =?utf-8?B?OXZvNEtyT3F6aVlpSzFPQzhrYWVKTjVhcmVHbm9SdkZNTnpDSk8wQjRpK0dH?= =?utf-8?B?UG1LcTBSQnJaOWJvZmhZTUdvN1FvbmZWa1JXY3hhemNDUDZKd3N2M09WejFT?= =?utf-8?B?cEQ1TC9QdXZ4N3NldzRnZTYyZ2c2Z0lINldIT1ZjRXNmbDBsN3ZKUnVLY2xs?= =?utf-8?B?NXgxZDVLaUFnVmpINXhzWTJiRnIyWHlzN0EvYjRVSyt2QXRSbGFnNnliNmJv?= =?utf-8?B?M1N6WFdEc2tLWHJRSTkzOEorL2NrRit5dGhpMWdxaitySzBFRGNQZm5QQVlO?= =?utf-8?B?dWsyMDY5MlVDZ1psMm55bk1lZVgxTVQ3TW5QZmduc3AyY1JLWlYyTFl2bllR?= =?utf-8?B?M1JwNUkwZTJhTXpYSHFtVWkyYll2THBsMkJlUFJtcStWQUs1czd1WnlDSjFl?= =?utf-8?B?Z2g1d3ZsT0VIVGF6N1lkam9aT0MrRmFGSUE1YjEwb01DTlhXbnhtZlRzVFRF?= =?utf-8?B?Vlg2ZlhRTm5iRFlTVWJ0MWZpLzZ0blFaaHhZVWxPR0lVN1N3YWRTTHQ2YlFB?= =?utf-8?B?UHdNVWNyb1NqM2xJSktoZWgxR3B5VGw2TnEvNGRJQUJZSHB4WjBrc1ZTMGdh?= =?utf-8?B?V1hENHg1b0wwWmxGLzdnMC9JZThlT0pXL0J0WFFPeU5KZ3ZNWWJlTWFHRVhy?= =?utf-8?B?TlVLWmhqVGI1UGlLUjg3VnQ4dU9lVGZ0clhLUlhzUDR6MGJjaW1rc0MwV25N?= =?utf-8?B?Si9Za0FCcXpESG9uQ2cvWGxoRCtvRFA4ZkhMODQ2WnNwRG9VNkJHbkp6aDVy?= =?utf-8?B?VmR5K3RHd3ZValNqUVpZK0JIRyt5N0k4THo4bEJDeitGWFRyTDYxM3ZLUkh4?= =?utf-8?B?ZG5wY0pUSWlPeHd0QlBkRHEzSjFOWlJYVkVuMUJGSEpjVzJmeTRkY0trMm5D?= =?utf-8?B?Tk9ROEhwanJNbThaUG80ZHJNUG1ETENjS2w0QW9iTSt4UHNvNHphQ0VyQjJY?= =?utf-8?B?enBDSldvdGU3T2drOFN2NzZSbjNWSG9iQ3NiVTA5NnZRQ2lsUlFKZGJTVkt2?= =?utf-8?B?emRXMWc3dHh2V3JUTElKa29BaGY1WnZONVc4QVh6aVhzSUF2WXlweVpER1Vj?= =?utf-8?B?WURSb2lFVkZpdkpRTkUrTXRyM1ZOTXZIVFFTTXRaZjJYSWFKUlNMR2hzMXph?= =?utf-8?B?QlZ6emlkaWxwLy9wQ1BaVjFPc3p2OXZrTFJWR3pyaFhMUlBPcTRCUnBiM1VU?= =?utf-8?B?d3d3RDBYZlB4ZzBzTFFXbmdCVkNOSWozUmJpVmVlY3l6QkhmRGlQRUtBeGVQ?= =?utf-8?B?SVVTQUtUanU5c0x2ZzNHVFRMSUMxaGpGZGZraFNGL3lOSjBvUC9jM0kzTXRB?= =?utf-8?B?MG4vanpGSjRURjJRZTF4RlJMbjYwSnJxRURpNnFlYm1LcjFmMGx3dWNOMnRr?= =?utf-8?Q?GsCTYGFd?= X-Microsoft-Exchange-Diagnostics: 1;BN1BFFO11HUB053;5:R4wYyjf7ss2rh/WpaYCi65igChtLrARxSGSLtntx73WltFK8MCvEECpBSV4fkmqnN1al5j8Ip106Ecm0+9OiB8IccE/4EYTQ5wrhXGBFHKJMXrLCphlT8VonIxVV5N9j/cKqzA8jCBAVh/hVVXOb7w==;24:PMwWd3U3b417x3RHvfxOkTM1qtJaPX8nZPXeYAibkoYl2N0mROvREC5iooBxijDPKefBYKBUAI14SCPyhYRbwlznJrUuMl9BnbQCAUIh7XE= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Aug 2015 11:44:11.5390 (UTC) X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.60.100];Helo=[xsj-pvapsmtpgw02] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN1BFFO11HUB053 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Ulf, On 08/27/2015 01:32 PM, Ulf Hansson wrote: > On 25 August 2015 at 14:04, Ulf Hansson wrote: >> On 6 August 2015 at 07:39, Michal Simek wrote: >>> Add GPIOLIB dependency for MMC_SDHCI. >>> >>> Problem was observed after adding the patch >>> "mmc: sdhci-of-arasan: Call OF parsing for MMC" >>> (sha1: 16b23787fc709fe60c5d2bd05927b1a3da33d4e9) which calls >>> mmc_of_parse() -> mmc_gpiod_request_cd() (slot-gpio.c) which >>> calls devm_gpiod_get_index() which returns -ENOSYS. >>> >>> Error log: >>> sdhci-arasan ff160000.sdhci: parsing dt failed (4294967258) >>> sdhci-arasan: probe of ff160000.sdhci failed with error -38 >>> >>> Signed-off-by: Michal Simek >> >> Thanks, applied for next! > > kbuild test robot reports a warning for this one, so I am dropping it > from my next branch. I think is just better to fix the problem there instead of dropping this patch which fix GPIO dependency. Fix is quite easy. diff --git a/arch/powerpc/platforms/44x/Kconfig b/arch/powerpc/platforms/44x/Kconfig index 5538e57c36c1..874f07c7d0b8 100644 --- a/arch/powerpc/platforms/44x/Kconfig +++ b/arch/powerpc/platforms/44x/Kconfig @@ -219,6 +219,7 @@ config AKEBONO select USB_EHCI_HCD_PLATFORM if USB_EHCI_HCD select MMC_SDHCI select MMC_SDHCI_PLTFM + select GPIOLIB select ATA select SATA_AHCI_PLATFORM help But the question is if we should keep these ancient targets in the tree. I am happy to send this patch but it should go via PPC tree. Or are you happy to apply it to your tree? Thanks, Michal