From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756285AbbH0MrZ (ORCPT ); Thu, 27 Aug 2015 08:47:25 -0400 Received: from bear.ext.ti.com ([192.94.94.41]:42924 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932223AbbH0MrU (ORCPT ); Thu, 27 Aug 2015 08:47:20 -0400 Message-ID: <55DF06CE.9030600@ti.com> Date: Thu, 27 Aug 2015 18:17:10 +0530 From: Kishon Vijay Abraham I User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.0 MIME-Version: 1.0 To: Ulf Hansson CC: Andreas Fenkart , Tony Lindgren , linux-mmc , linux-omap , "linux-kernel@vger.kernel.org" , Sekhar Nori , Neil Brown Subject: Re: [PATCH v3 13/15] mmc: host: omap_hsmmc: use regulator_is_enabled to find pbias status References: <1440666847-12594-1-git-send-email-kishon@ti.com> <1440666847-12594-14-git-send-email-kishon@ti.com> In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Uffe, On Thursday 27 August 2015 06:12 PM, Ulf Hansson wrote: > On 27 August 2015 at 14:41, Ulf Hansson wrote: >> On 27 August 2015 at 11:14, Kishon Vijay Abraham I wrote: >>> Use regulator_is_enabled of pbias regulator to find pbias regulator >>> status instead of maintaining a custom bookkeeping >>> pbias_enabled variable. >> >> Doesn't this cause a problem for the scenario when the initial state >> of the regulator is enabled? Patch 11 of this series "mmc: host: omap_hsmmc: don't use ->set_power to set initial regulator state" disables the pbias regulator if the initial state of the regulator is enabled. Thanks Kishon >> >> Both in the sense that you will increase the enable count for it > > /s/will/won't > >> (potentially it may then become disabled when you need it enabled) but >> also from a enable/disable imbalance point of view. >> >> Kind regards >> Uffe >> >>> >>> Signed-off-by: Kishon Vijay Abraham I >>> Tested-by: Tony Lindgren >>> --- >>> drivers/mmc/host/omap_hsmmc.c | 8 ++------ >>> 1 file changed, 2 insertions(+), 6 deletions(-) >>> >>> diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c >>> index 5a5946a..4cd7a58 100644 >>> --- a/drivers/mmc/host/omap_hsmmc.c >>> +++ b/drivers/mmc/host/omap_hsmmc.c >>> @@ -182,7 +182,6 @@ struct omap_hsmmc_host { >>> struct clk *fclk; >>> struct clk *dbclk; >>> struct regulator *pbias; >>> - bool pbias_enabled; >>> void __iomem *base; >>> int vqmmc_enabled; >>> resource_size_t mapbase; >>> @@ -330,22 +329,20 @@ static int omap_hsmmc_set_pbias(struct omap_hsmmc_host *host, bool power_on, >>> return ret; >>> } >>> >>> - if (host->pbias_enabled == 0) { >>> + if (!regulator_is_enabled(host->pbias)) { >>> ret = regulator_enable(host->pbias); >>> if (ret) { >>> dev_err(host->dev, "pbias reg enable fail\n"); >>> return ret; >>> } >>> - host->pbias_enabled = 1; >>> } >>> } else { >>> - if (host->pbias_enabled == 1) { >>> + if (regulator_is_enabled(host->pbias)) { >>> ret = regulator_disable(host->pbias); >>> if (ret) { >>> dev_err(host->dev, "pbias reg disable fail\n"); >>> return ret; >>> } >>> - host->pbias_enabled = 0; >>> } >>> } >>> >>> @@ -2081,7 +2078,6 @@ static int omap_hsmmc_probe(struct platform_device *pdev) >>> host->base = base + pdata->reg_offset; >>> host->power_mode = MMC_POWER_OFF; >>> host->next_data.cookie = 1; >>> - host->pbias_enabled = 0; >>> host->vqmmc_enabled = 0; >>> >>> ret = omap_hsmmc_gpio_init(mmc, host, pdata); >>> -- >>> 1.7.9.5 >>>