From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754019AbbH0NUn (ORCPT ); Thu, 27 Aug 2015 09:20:43 -0400 Received: from devils.ext.ti.com ([198.47.26.153]:54932 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752479AbbH0NUl (ORCPT ); Thu, 27 Aug 2015 09:20:41 -0400 Message-ID: <55DF0E9E.4010000@ti.com> Date: Thu, 27 Aug 2015 18:50:30 +0530 From: Kishon Vijay Abraham I User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.0 MIME-Version: 1.0 To: Ulf Hansson CC: Andreas Fenkart , Tony Lindgren , linux-mmc , linux-omap , "linux-kernel@vger.kernel.org" , Sekhar Nori , Neil Brown Subject: Re: [PATCH v3 00/15] omap_hsmmc: regulator usage cleanup and fixes References: <1440666847-12594-1-git-send-email-kishon@ti.com> In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday 27 August 2015 06:39 PM, Ulf Hansson wrote: > On 27 August 2015 at 11:13, Kishon Vijay Abraham I wrote: >> This patch series does the following >> *) Uses devm_regulator_get_optional() for vmmc and then removes the >> CONFIG_REGULATOR check altogether. >> *) return on -EPROBE_DEFER and any other fatal errors >> *) enable/disable vmmc_aux regulator based on prior state >> >> Changes from v2: >> *) rebased to mmc -next branch >> *) dropped using "mmc_of_parse_voltage" to get ocr_avail patch. >> >> Changes from v1: >> *) return on -EPROBE_DEFER and other fatal errors. (Don't return only >> if the return value is -ENODEV) >> *) Remove the beagle x15 dts patch. It can be part of a different >> series. >> *) Avoid using regulator_is_enabled for vqmmc since if the regulator >> is shared and the other users are not using regulator_is_enabled >> then there can be unbalanced regulator_enable/regulator_disable >> >> I've pushed this patch series to >> git://git.ti.com/linux-phy/linux-phy.git mmc_for-next >> >> Please note the branch also has the pbias fixes [1]. >> [1] -> https://lkml.org/lkml/2015/7/27/358 >> >> This series is in preparation for implementing the voltage switch >> sequence so that UHS cards can be supported. >> >> Did basic read/write test in J6, J6 Eco, Beagle-x15, AM437x EVM, >> Beaglebone black, OMAP5 uEVM, OMAP4 PANDA and OMAP3gle xm. >> >> Kishon Vijay Abraham I (15): >> mmc: host: omap_hsmmc: use devm_regulator_get_optional() for vmmc >> mmc: host: omap_hsmmc: return on fatal errors from omap_hsmmc_reg_get >> mmc: host: omap_hsmmc: cleanup omap_hsmmc_reg_get() >> mmc: host: omap_hsmmc: use the ocrmask provided by the vmmc regulator >> mmc: host: omap_hsmmc: use mmc_host's vmmc and vqmmc >> mmc: host: omap_hsmmc: remove unnecessary pbias set_voltage >> mmc: host: omap_hsmmc: return error if any of the regulator APIs fail >> mmc: host: omap_hsmmc: add separate functions for enable/disable >> supply >> mmc: host: omap_hsmmc: add separate function to set pbias >> mmc: host: omap_hsmmc: avoid pbias regulator enable on power off >> mmc: host: omap_hsmmc: don't use ->set_power to set initial regulator >> state >> mmc: host: omap_hsmmc: enable/disable vmmc_aux regulator based on >> previous state >> mmc: host: omap_hsmmc: use regulator_is_enabled to find pbias status >> mmc: host: omap_hsmmc: use ios->vdd for setting vmmc voltage >> mmc: host: omap_hsmmc: remove CONFIG_REGULATOR check >> >> drivers/mmc/host/omap_hsmmc.c | 326 +++++++++++++++++++++++++++-------------- >> 1 file changed, 212 insertions(+), 114 deletions(-) >> >> -- >> 1.7.9.5 >> > > Thanks, applied for next! Thank you. -Kishon