From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755216AbbH0O0m (ORCPT ); Thu, 27 Aug 2015 10:26:42 -0400 Received: from mail-by2on0055.outbound.protection.outlook.com ([207.46.100.55]:30107 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754014AbbH0O0i (ORCPT ); Thu, 27 Aug 2015 10:26:38 -0400 Authentication-Results: spf=pass (sender IP is 149.199.60.100) smtp.mailfrom=xilinx.com; linaro.org; dkim=none (message not signed) header.d=none;linaro.org; dmarc=bestguesspass action=none header.from=xilinx.com; Subject: Re: [PATCH] mmc: Kconfig: Add dependency on GPIOLIB for MMC_SDHCI To: Ulf Hansson , Michal Simek References: <6906e34b62f162018984a5fbd12b3ef6cd5e3a29.1438839562.git.michal.simek@xilinx.com> <55DEF7FD.8020904@xilinx.com> <55DF1413.3030004@xilinx.com> CC: "linux-kernel@vger.kernel.org" , "Michal Simek" , Scott Branden , Weijun Yang , Andrew Bresticker , "Jean Delvare" , Srinivas Kandagatla , linux-mmc , "Alim Akhtar" , addy ke , "Stephen Boyd" , Chaotian Jing , Kevin Hao , Vincent Yang From: Michal Simek X-Enigmail-Draft-Status: N1110 Message-ID: <55DF1E0C.70505@xilinx.com> Date: Thu, 27 Aug 2015 16:26:20 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-RCIS-Action: ALLOW X-TM-AS-Product-Ver: IMSS-7.1.0.1224-8.0.0.1202-21774.005 X-TM-AS-User-Approved-Sender: Yes;Yes X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1;BL2FFO11FD033;1:7fZ1W3+sg1zw+rqvsnqY0WicHH3i5GOlzI7ZI15yWjHJ9q1EybtRZw6BvrkyJw+zsNLfXC0ko3S/K1vDnTf840VKHuOGuaXaqW3hnkNOblshVtFUOmJGyQKnHJatsARP/9oE7GToTN3Fq773OP3jiLzDC7W0i3V2lzggpaXft9XTHLTZfubGNw+7pwXdogWObCe2Z99BVNXy7kN8pxD1TIh73tzjgDRwG/Fbs1NXd8T3Klmgn7ZcgvPz5vgCFIk2hsH11eP/zJxHyzVQMln88zTw+jLncdGhoBdVFe81ftU0tZbK3B6mX6F6xQCa3sYtQBgKxRstdl9pJ9BQRkPKZQ== X-Forefront-Antispam-Report: CIP:149.199.60.100;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(438002)(3050300001)(164054003)(199003)(479174004)(52604005)(24454002)(377454003)(189002)(92566002)(4001350100001)(36386004)(81156007)(65816999)(2950100001)(77156002)(4001540100001)(106466001)(33656002)(5001860100001)(5001830100001)(77096005)(76176999)(50986999)(4001450100002)(36756003)(54356999)(5001960100002)(62966003)(189998001)(5001770100001)(65806001)(47776003)(6806004)(65956001)(19580395003)(19580405001)(50466002)(93886004)(64126003)(64706001)(83506001)(63266004)(5007970100001)(23676002)(575784001)(46102003)(86362001)(87936001)(107986001)(5001870100001);DIR:OUT;SFP:1101;SCL:1;SRVR:BL2FFO11HUB008;H:xsj-pvapsmtpgw02;FPR:;SPF:Pass;PTR:xapps1.xilinx.com,unknown-60-100.xilinx.com;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BL2FFO11HUB008;2:bNTb1Qf9JTu8vIlXyVx5iBoEgg6LcPpAcWxJVwUbMR6hnrzDF4K5hzh48RxfhMNsi6/icCOthryH7jSs+WNkhbNmNbrw2HSBUkp2bdKq/IbtdCE1cJEsDhfqsjgncfe4Md/bWiCcBvMSW0qokwoOlwewaDBHuGAEM8izXM2/csA=;3:z96dniFS47wBlmSxqXL1nLboF9oDTmEqQFZprxu4KLbuLZ2GZ8d4VKOsS9M2LU3cNotcioUwwc5jGAlpR+0TMH1/jTqMdEIGRZqSsAlvY+qIyOfXw1w/lTOCR0H5BAu/ob6kO40B9VAWRKqX6NifmGzOLOIuGS+8nujm+3ynOUZniaY9kcNsyJfw7HLKcNEDttq8l9tJc2kEUhaPqUOKyCeo/OaB6iEeS1s4z+ancZOJiv0DeIIv1s56omUm0YNYwN14rBvjR5wwJTNhBmZiaQ==;25:EICM1ixawPOoNuBkjUDvprknJQHxbVjoi2gqeL9yKWo+u0J0yGaXGVz7bvjAS9Zr6bgtDoQvFX9ICr/3abnLMsUk5BAhOdAngJSRUrNoVXCmk4tWEFlNxNoxiOrriZZ2iGhsI5JKC9z0jaWdMCLb/84HnvH2bpEd0VuSQ7UpiXl3SPQR2gaSa/+o4csOB53tkuQFxb3vkgOfhOdMAtPcYI9kPAaox5ZkMNX0p9Y3q2njS686tiV8WnhTWCwU5EBY5m/CJETnghidWJCCfSbFOA== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(8251501001);SRVR:BL2FFO11HUB008; X-Microsoft-Exchange-Diagnostics: 1;BL2FFO11HUB008;20:DdWFE1L5l6/eXWarZKYE9Y/DxHb48W5hYQJ2zbbjLa8FVwKCF2FJhSAkRAaGvtwVsebLCUIXNOSzmJMCS6pzrgV4obaGz9s99AwtHdtSBsVNFh/v1dM7iuB9b7NGxX5my9Nq5kUWp9L2Top5XfgqV2/33QPaXnnslH7ajcq3MHfwACykJZkA+fmnz6mE7+IUOOE6NET90sMpK10nPB6EaNCytH4mJtBkjzf1HfMmvTRiVwbzcXtVpuI/BNwKHSt2yTA5L28ACNWMVchr2nDApzJNxuceuFmpgPN/7xkk7tOyKE3yPcetnddoVzPPfwt852JTgBjLhNEKyGbt6TQ7DWKKecmGoFmTRrsPLq4WGUCSHaDYoJn7taonDcPoXdWzRPAHEqvwnMDVZUCoMtFoR/Ry360L+YLLH/IMmnPfhySI6sNXHNj1EFT91Zb5Nt0UTJxtFwZ0GPh/qXyubqSrMJGboDZn+GjOn70kDkPmdojRko2fJV88jFQZ4ocRr+Zr;4:JevzdslSzRq/EZoTjhI0fvHvckp4KmOzPWVmupIhReJ6epW7/np8elhIngJImBb+PrfkCPcJFK6Zi59hQ+mw81W6GUV9Dq49kAWtfyWWZdocRfOdg5pHIn9qNhOHMqpTcgyv0pQz0Sp1PTuHHeofl5PinPw7dEfdt13SDDiXdZ7uZMFBecv1f4HO/8bKs4UvQNmSom89kJO9jMxTsm7aq45aAyvDGaWkl38CUG+eEXtZKeq7yv2xgM/nhL0XsbMUwbHg18z0s++Zf+keJICxpgyGDf5FFeTIz/ZA5J8JhTHuEbsnudrRvt8D4mW9nIOyTdX4CVvoRRS4WcYvYxCjxQ== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(5005006)(8121501046)(3002001);SRVR:BL2FFO11HUB008;BCL:0;PCL:0;RULEID:;SRVR:BL2FFO11HUB008; X-Forefront-PRVS: 06818431B9 X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCTDJGRk8xMUhVQjAwODsyMzpuSEQ2MWFNUGF4N2VMT2psbzdkSU12R05l?= =?utf-8?B?OFhIdXVSOUhYSVAyQWVkK0R2bnF6ZVlNOWVxTGdkR2hvR1dLbDNWNHMrYW5l?= =?utf-8?B?VktCdTlkVkI4dUE3NlkrcUpoTHBIL2dNOHJpTHFKWkZQYnpXZmdNTDd1S1o1?= =?utf-8?B?ekRXTmp3dmVaUjVyZ0ZLTXBhYWtEdXlaSFhjUGZnb0xoOGxnSzdlRzNPS3NT?= =?utf-8?B?c3JLdzVtWEw3NzJVdkhXcWtzQWxodk8vc09KYVdLSzVCMVllQVRaL3dKdXU5?= =?utf-8?B?OVkzdUNsOSsxTjFOTXhXUmxIR0duRFZFYitTRHlZOFJVcTIvWnZaWXc2K25z?= =?utf-8?B?dE9EQUZiNXFaWVFNOVR2aWhZbWZCNHlGd1BucmdqbTd0K1RMeERmNXNXdVNX?= =?utf-8?B?K2VmbzU4UTZrU2ZZUEVKWGU1TnNoZ1dMdjJlckJBYTc0OGdZZXNXUEMvZFVh?= =?utf-8?B?WlBOTmFsR3RuSy9sdk5ycnlvU1RzZGVZVFc1RUErendzbHN6NFZZSDE0NW1q?= =?utf-8?B?bGRPdEFOSTJOa3dKMzZMTmRSNVkzRUxuMlJzcktSRGd3NnJ2eCtSbnN2WG9O?= =?utf-8?B?MXBNUHI2bzFMclZ2cVFkVmNYZVpiaWpSV0Z4TGZiekh4NDQ3dUNZdDhGdGxo?= =?utf-8?B?VWhyMG95SlcvdHkrd2h4UzNza0IxdDViSnQ5NTEzc3JLMzhSeXgvL1FCTmV6?= =?utf-8?B?NlNLaTVlWlRKeFR3dTVLdjlmdWtzakVZcnhZd2hVQlRqaWk5ZWRHdUxhcGEz?= =?utf-8?B?ZnNYTWJTUkFaSy9CZU1NVWIwb1JSMExWS0RQMVZERzRWMFo0S1pGb25ybnFC?= =?utf-8?B?ckEwNm1Lalo5eVRhdHFMaE5hS3Z3Z3NtWmJkWDRWdjhqUFNlU0ZzTFBqeTNU?= =?utf-8?B?OVB6cEF3WmFJc25HTitJeUFEU2M3aXFoUzc4WE9CUWZtQk1LTmkxenJiM3pv?= =?utf-8?B?aTZ0MUZ2bS9tdzVETzAxdFBOQXd1dU4yTTVYVzhjS3V0WlN0RHNNbXdlaVZH?= =?utf-8?B?YUROeGRHcGVRK09HRmQxSFVQQURLVU50VDZUVzhyZFF3djM2N0JzUVEveFQ5?= =?utf-8?B?RFViTGRTK2pZQ21NaVpYdlFXVkJNZmhRalAvNHNQTTRZd25UYS9vRnFaWXY0?= =?utf-8?B?VmdUWVdXeTg2UXZHZ28zSitJRHhQN1VENklLaURTc09GUGVwTHBQbk83WVZZ?= =?utf-8?B?cTVpbHZ5bGY3YXNsMGNaNnFoQU5vVkxIU3ZEbFlNWm1kQ1VBUk41Unc1SWhz?= =?utf-8?B?bHF0SzdIUUhUbFdUZHZWaG1qUk0yRUhNWWJjMU50dEJHbnJFYWc5SDhtMmZB?= =?utf-8?B?ZlJGRExFT0xiQkppZGpwOHlxd0xubEtncmpObE9TOGJZazFxMGt5dUd6VmFy?= =?utf-8?B?WmxZUUV2OGhPSWkvd2pGcHlrVUJNK1J0UGxVOXNGRkt3UDZDcHRydmZuUURL?= =?utf-8?B?R3JReGxadWo3akpqNGkyWnJjUHR6M2Vyb2tkNWZBTllDeUJtOVRWRkQ2QkJ0?= =?utf-8?B?UjdNc0JITmYvZUVGMkdBM3AwVGdKUjZLZ0Izanh3eDBvMG5jdFNNQllDOGVo?= =?utf-8?B?Vnp4Tkh6TTVuOTZwUkhxQ29iSDk5UWlLSTJzYnh6dU93TGprc2dPWXZMbHdN?= =?utf-8?B?bGh3VnNOMW5hMkJWVEl0cWJvUkFydHJVemJDNjNDVFFCYm1vS3k4aGpzbGdn?= =?utf-8?B?ajdsdk0xWXJzaEFKU2dJNTNYc1BBdTNVQ254eUlGUk9mRWlBSlBLTGNLdDF3?= =?utf-8?B?UDZIa0ZUL0FtT0RTNmtDYlhnbzVCSjhoQTFwSmVObC9uR1U3QWFqVUFLK096?= =?utf-8?B?VGJUUUZnbmNqWTI4Y0g3SkpYbWhWancvZWpyRXQ4eXQyUGhFZm1haTlQVW9a?= =?utf-8?B?Nk5tK0NFaWt5cmt4a3FROG5qZTUvN2JBUjRFYmhFRUwrSUFMaXhHcnRFekdV?= =?utf-8?B?bGVzWm5sT2phUT09?= X-Microsoft-Exchange-Diagnostics: 1;BL2FFO11HUB008;5:tnJuM/S3Anck6VV3hR01swwhR6J8T50dIILsoxxfaQDzZeU+2PG6Kd9NmFippzhMZY3LZwf5Qkue9wp+lkdq/vPAgQSmKauf5Xy1uMYdzXiehGMcSzru2zDFQ+q4rV6Rh7WBDAjxt+tiSwIvaxhCsw==;24:T48VpKuO6LI8Zj9XUo9jNy42YrZoiCwzjrVWZP1UqD9hMU8z8SECKZKAMIplQzGMcKBUZvQRuPBAiKsNZXJuMngAG4E2LE79dU/8YuUkPrs= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Aug 2015 14:26:36.3304 (UTC) X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.60.100];Helo=[xsj-pvapsmtpgw02] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL2FFO11HUB008 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/27/2015 04:12 PM, Ulf Hansson wrote: > On 27 August 2015 at 15:43, Michal Simek wrote: >> On 08/27/2015 02:30 PM, Ulf Hansson wrote: >>> On 27 August 2015 at 13:43, Michal Simek wrote: >>>> Hi Ulf, >>>> >>>> On 08/27/2015 01:32 PM, Ulf Hansson wrote: >>>>> On 25 August 2015 at 14:04, Ulf Hansson wrote: >>>>>> On 6 August 2015 at 07:39, Michal Simek wrote: >>>>>>> Add GPIOLIB dependency for MMC_SDHCI. >>>>>>> >>>>>>> Problem was observed after adding the patch >>>>>>> "mmc: sdhci-of-arasan: Call OF parsing for MMC" >>>>>>> (sha1: 16b23787fc709fe60c5d2bd05927b1a3da33d4e9) which calls >>>>>>> mmc_of_parse() -> mmc_gpiod_request_cd() (slot-gpio.c) which >>>>>>> calls devm_gpiod_get_index() which returns -ENOSYS. >>>>>>> >>>>>>> Error log: >>>>>>> sdhci-arasan ff160000.sdhci: parsing dt failed (4294967258) >>>>>>> sdhci-arasan: probe of ff160000.sdhci failed with error -38 >>>>>>> >>>>>>> Signed-off-by: Michal Simek >>>>>> >>>>>> Thanks, applied for next! >>>>> >>>>> kbuild test robot reports a warning for this one, so I am dropping it >>>>> from my next branch. >>>> >>>> I think is just better to fix the problem there instead of dropping this >>>> patch which fix GPIO dependency. >>>> >>>> Fix is quite easy. >>>> diff --git a/arch/powerpc/platforms/44x/Kconfig >>>> b/arch/powerpc/platforms/44x/Kconfig >>>> index 5538e57c36c1..874f07c7d0b8 100644 >>>> --- a/arch/powerpc/platforms/44x/Kconfig >>>> +++ b/arch/powerpc/platforms/44x/Kconfig >>>> @@ -219,6 +219,7 @@ config AKEBONO >>>> select USB_EHCI_HCD_PLATFORM if USB_EHCI_HCD >>>> select MMC_SDHCI >>>> select MMC_SDHCI_PLTFM >>>> + select GPIOLIB >>>> select ATA >>>> select SATA_AHCI_PLATFORM >>>> help >>>> >>>> But the question is if we should keep these ancient targets in the tree. >>>> >>>> I am happy to send this patch but it should go via PPC tree. Or are you >>>> happy to apply it to your tree? >>> >>> It's getting really late for 4.3 so I would rather postpone this to >>> the next release cycle. >> >> No problem at all. :-) >> >>> >>> As I stated in my earlier reply, do we really want to add the GPIOLIB >>> dependency to the Kconfig file for SDHCI? >>> I assume we have lots of other Kconfig dependencies, then these should >>> also to be added for the same reasons. I doubt this is the right thing >>> to do. >> >> Is it the right solution not to list them if they are there? > > Well, I don't think there are *one* answer to this. > > Still, the reason to why we have API implementing stubs when used is > to manage these cases. > >> >>> How about if the mmc core instead treat GPIOs as optional from an API >>> point of view and thus it won't cause ->probe() to fail. Is that a way >>> forward for you? >> >> In my test case I am not using GPIO at all and probe is failing. If this >> is fixed because it is probably common setting for others we don't need >> to list this dependency. >> But really for my case and I am not using gpio at all probe just failed >> which is incorrect and should be fixed. >> > > Thanks for clarifying. In this regard I think it's pretty obvious that > we need to make GPIO optional. > Else we will force the footprint to increase for the kernel image, > even when not needed. right. Footprint is valid argument. > > Typically checking for -ENOSYS from the response from the GPIOLIB > would do the trick. That's actually what we do already for GPIOs in > mmc pwrseq simple case. I didn't parse the gpio code to be 100% sure that this is enough. Also if this will cover all cases which we can have. Depends on gpio error code consistency. > Do you want to send another patch? I would love to but I am quite occupied right now but I am happy to test on our SoC when we have right fix for it. Thanks, Michal