Re: [PATCH v1 3/5] ARM: dts: Add arm, pl330-broken-no-flushp quirk for rk3288 platform

[Shawn Lin <shawn.lin@rock-chips.com>]

On 2015/8/28 0:52, Doug Anderson wrote:
> Hi,
>
> On Thu, Aug 27, 2015 at 7:24 AM, Shawn Lin <shawn.lin@rock-chips.com> wrote:
>> From: Addy Ke <addy.ke@rock-chips.com>
>
> Looks like you just added the "From" here.  I think that's fine, but
> better to set the author so you get the right cover letter...
>
>
>> Pl330 integrated in rk3288 platform doesn't support
>> DMAFLUSHP function. So we add broken-no-flushp quirk
>> for it.
>>
>> Signed-off-by: Addy Ke <addy.ke@rock-chips.com>
>> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
>> cc: Heiko Stuebner <heiko@sntech.de>
>> cc: Doug Anderson <dianders@chromium.org>
>> cc: Olof Johansson <olofj@google.com>
>>
>> ---
>>
>> Changes in v1:
>> - rename broken-no-flushp to "arm,pl330-broken-no-flushp" suggested
>>    by Krzysztof.
>> - remove Sunny's tag
>
> Note that typically for patches I see people go from "no v" to "v2".  AKA:
> * PATCH
> * PATCH v2
> * PATCH v3
>
>
>>   arch/arm/boot/dts/rk3288.dtsi | 3 +++
>>   1 file changed, 3 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi
>> index 22316d0..106adf7 100644
>> --- a/arch/arm/boot/dts/rk3288.dtsi
>> +++ b/arch/arm/boot/dts/rk3288.dtsi
>> @@ -144,6 +144,7 @@
>>                          #dma-cells = <1>;
>>                          clocks = <&cru ACLK_DMAC2>;
>>                          clock-names = "apb_pclk";
>> +                       arm,pl330-broken-no-flushp;
>
> Note that you should add bindings _before_ the usage of them.  So
> patch #5 (Documentation) needs to come before this one.
>

Cool! That makes sense.
Thanks, Doug.

>>                  };
>>
>>                  dmac_bus_ns: dma-controller@ff600000 {
>> @@ -155,6 +156,7 @@
>>                          clocks = <&cru ACLK_DMAC1>;
>>                          clock-names = "apb_pclk";
>>                          status = "disabled";
>> +                       arm,pl330-broken-no-flushp;
>>                  };
>>
>>                  dmac_bus_s: dma-controller@ffb20000 {
>> @@ -165,6 +167,7 @@
>>                          #dma-cells = <1>;
>>                          clocks = <&cru ACLK_DMAC1>;
>>                          clock-names = "apb_pclk";
>> +                       arm,pl330-broken-no-flushp;
>>                  };
>>          };
>
> Other than the small nits above, this looks fine to me.
>
> Reviewed-by: Douglas Anderson <dianders@chromium.org>
>
>
>


-- 
Best Regards
Shawn Lin