From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752037AbbHaIRS (ORCPT ); Mon, 31 Aug 2015 04:17:18 -0400 Received: from lists.s-osg.org ([54.187.51.154]:33027 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750960AbbHaIRQ (ORCPT ); Mon, 31 Aug 2015 04:17:16 -0400 Subject: Re: [PATCH] power: Remove unnecessary MODULE_ALIAS() for I2C drivers To: =?UTF-8?Q?Pali_Roh=c3=a1r?= References: <1440976715-23588-1-git-send-email-javier@osg.samsung.com> <20150831071710.GA14484@pali> Cc: linux-kernel@vger.kernel.org, "linux-pm@vger.kernel.org" , Sebastian Reichel , Dmitry Eremin-Solenikov , David Woodhouse From: Javier Martinez Canillas Message-ID: <55E40D87.8030405@osg.samsung.com> Date: Mon, 31 Aug 2015 10:17:11 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.0.1 MIME-Version: 1.0 In-Reply-To: <20150831071710.GA14484@pali> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [adding cc list again] Hello Pali, On 08/31/2015 09:17 AM, Pali Rohár wrote: > On Monday 31 August 2015 01:18:35 Javier Martinez Canillas wrote: >> These drivers already have an I2C device id table that is used to create >> module aliases and the used MODULE_ALIAS() was either already in the I2C >> table so it was redundant or wasn't a valid I2C id so it was never used. >> >> Signed-off-by: Javier Martinez Canillas >> >> --- >> >> diff --git a/drivers/power/bq27x00_battery.c b/drivers/power/bq27x00_battery.c >> index 8287261fd978..d0b2f3b47b8f 100644 >> --- a/drivers/power/bq27x00_battery.c >> +++ b/drivers/power/bq27x00_battery.c >> @@ -1120,10 +1120,6 @@ module_exit(bq27x00_battery_exit); >> MODULE_ALIAS("platform:bq27000-battery"); >> #endif >> >> -#ifdef CONFIG_BATTERY_BQ27X00_I2C >> -MODULE_ALIAS("i2c:bq27000-battery"); >> -#endif >> - >> MODULE_AUTHOR("Rodolfo Giometti "); >> MODULE_DESCRIPTION("BQ27x00 battery monitor driver"); >> MODULE_LICENSE("GPL"); > > Hi! This part of patch is already in queue list. So then your patch will > conflict with other pending patches... > Sorry, with which patch it will conflict? It applies cleanly on top of the power supply git tree next branch: https://git.kernel.org/cgit/linux/kernel/git/sre/linux-power-supply.git/log/?h=next Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America