From: Kirill Tkhai <ktkhai@odin.com>
To: <linux-kernel@vger.kernel.org>
Cc: Tejun Heo <tj@kernel.org>, Li Zefan <lizefan@huawei.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: [PATCH] cgroup, cleanup: Delete PF_EXITING checks from cgroup_exit() callbacks
Date: Mon, 31 Aug 2015 14:49:59 +0300 [thread overview]
Message-ID: <55E43F67.6070407@odin.com> (raw)
Remove useless checks and outdates commentaries.
Signed-off-by: Kirill Tkhai <ktkhai@odin.com>
---
kernel/events/core.c | 8 --------
kernel/sched/core.c | 8 --------
2 files changed, 16 deletions(-)
diff --git a/kernel/events/core.c b/kernel/events/core.c
index ae16867..94bd500 100644
--- a/kernel/events/core.c
+++ b/kernel/events/core.c
@@ -9219,14 +9219,6 @@ static void perf_cgroup_exit(struct cgroup_subsys_state *css,
struct cgroup_subsys_state *old_css,
struct task_struct *task)
{
- /*
- * cgroup_exit() is called in the copy_process() failure path.
- * Ignore this case since the task hasn't ran yet, this avoids
- * trying to poke a half freed task state from generic code.
- */
- if (!(task->flags & PF_EXITING))
- return;
-
task_function_call(task, __perf_cgroup_move, task);
}
diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index b3386c6..f8509be 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -8167,14 +8167,6 @@ static void cpu_cgroup_exit(struct cgroup_subsys_state *css,
struct cgroup_subsys_state *old_css,
struct task_struct *task)
{
- /*
- * cgroup_exit() is called in the copy_process() failure path.
- * Ignore this case since the task hasn't ran yet, this avoids
- * trying to poke a half freed task state from generic code.
- */
- if (!(task->flags & PF_EXITING))
- return;
-
sched_move_task(task);
}
next reply other threads:[~2015-08-31 11:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-31 11:49 Kirill Tkhai [this message]
2015-08-31 11:53 ` [PATCH] cgroup, cleanup: Delete PF_EXITING checks from cgroup_exit() callbacks Peter Zijlstra
2015-08-31 12:12 ` Kirill Tkhai
2015-08-31 13:37 ` Peter Zijlstra
2015-09-13 11:01 ` [tip:sched/core] sched/core: Delete PF_EXITING checks from cpu_cgroup_exit() callback tip-bot for Kirill Tkhai
2015-09-13 11:09 ` [tip:perf/core] perf/core: Delete PF_EXITING checks from perf_cgroup_exit() callback tip-bot for Kirill Tkhai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55E43F67.6070407@odin.com \
--to=ktkhai@odin.com \
--cc=a.p.zijlstra@chello.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox