From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754113AbbHaTOl (ORCPT ); Mon, 31 Aug 2015 15:14:41 -0400 Received: from mx0b-00082601.pphosted.com ([67.231.153.30]:34311 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752310AbbHaTOj (ORCPT ); Mon, 31 Aug 2015 15:14:39 -0400 Subject: Re: [GIT PULL] bcache revert To: Kent Overstreet , , References: <20150831190050.GC27538@kmo-pixel> From: Jens Axboe Message-ID: <55E4A77F.7030802@fb.com> Date: Mon, 31 Aug 2015 13:14:07 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <20150831190050.GC27538@kmo-pixel> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [192.168.54.13] X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.14.151,1.0.33,0.0.0000 definitions=2015-08-31_02:2015-08-31,2015-08-31,1970-01-01 signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/31/2015 01:00 PM, Kent Overstreet wrote: > Linus, please pull; this reverts a patch from Jens that was committed without > CCing be or being mailed out to any of the lists. Said patch wasn't in any way a > functional change and is something that damn well should have been discussed. > > Jens - what the goddamn fuck!? You've never touched the bcache code until now, > and when you finally get interested this is what you do!? > > While I am sympathetic to the arguments in favor of your patch, there _are_ some > damn good reasons I did it the way I did. If you want to have that discussion, > feel free to mail your patch out again after the revert. The patch was part of a larger series that I was working on, and I just wanted to flush out that dependency. Christoph review and acked it, it was by no means a sneaking in of a patch. So calm down. Is there a bug? The previous code was crap, having hidden returns in macros is horrible. The upstream bcache code has been effectively unmaintained for more than a year, and THIS patch is now a problem? Get real. -- Jens Axboe