From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754480AbbIAAKB (ORCPT ); Mon, 31 Aug 2015 20:10:01 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57595 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754461AbbIAAJ7 (ORCPT ); Mon, 31 Aug 2015 20:09:59 -0400 Message-ID: <55E4ECD6.5010006@redhat.com> Date: Mon, 31 Aug 2015 20:09:58 -0400 From: Prarit Bhargava User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: "Winkler, Tomas" , Heikki Krogerus CC: Linux Kernel , Samuel Ortiz , "Kershner, David A" , Ben Romer Subject: Re: [PATCH] mei, make modules.alias UUID information easier to read References: <1439557540-1989-1-git-send-email-prarit@redhat.com> <55E04B1C.90907@redhat.com> <20150828124604.GA8767@kuha.fi.intel.com> <5B8DA87D05A7694D9FA63FD143655C1B3D43214F@hasmsx108.ger.corp.intel.com> In-Reply-To: <5B8DA87D05A7694D9FA63FD143655C1B3D43214F@hasmsx108.ger.corp.intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/29/2015 05:21 PM, Winkler, Tomas wrote: >> >> Hi Prarit, >> >> On Fri, Aug 28, 2015 at 07:50:52AM -0400, Prarit Bhargava wrote: >>> Heikki, Tomas? >> >> I'm afraid I don't know much about Intel's Management Engine >> Interface. Looks like the driver is from Samuel (CC'd) so I'm guessing >> he is the person you wanted comments from and not me. >> > > The patch was done against the master branch instead of char-misc-next so it doesn't apply. Anyhow I've rebased it already and I'm testing it. > I will probably re-post it, with your permission with my other mei bus fixes. > Yep, only requires some minor adjustments in order to apply to char-misc-next. Please repost when you can. FYI: this is needed to bring drivers/staging/unisys out of the staging directory. > BTW, I took the inspiration from vmbus in regards to uuid representation so it if the uuid sting hurts you, you may fix vmbus as well. I don't have any vmbus setup and I try not to fix things I cannot check. > I didn't recall other users of add_uuid() but took a look anway. do_vmbus_entry() doesn't call add_uuid() like do_mei_entry() does. However, the vmbus code should also just simply use add_uuid(). I can do that after this patch gets into the kernel, as it isn't absolutely necessary to fix like do_mei_entry(). It should be a trivial drivers/hv patch to fix all that up. P.