From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754090AbbIAG1Y (ORCPT ); Tue, 1 Sep 2015 02:27:24 -0400 Received: from mga02.intel.com ([134.134.136.20]:56275 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752712AbbIAG1X (ORCPT ); Tue, 1 Sep 2015 02:27:23 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.17,447,1437462000"; d="scan'208";a="795206464" Message-ID: <55E5448E.40001@intel.com> Date: Tue, 01 Sep 2015 09:24:14 +0300 From: Adrian Hunter Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki, Business Identity Code: 0357606 - 4, Domiciled in Helsinki User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: Jiri Olsa CC: Wang Nan , acme@kernel.org, linux-kernel@vger.kernel.org, lizefan@huawei.com, pi3orama@163.com, Arnaldo Carvalho de Melo Subject: Re: [PATCH] perf tools: Fix random building error References: <1441087005-107540-1-git-send-email-wangnan0@huawei.com> In-Reply-To: <1441087005-107540-1-git-send-email-wangnan0@huawei.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/09/15 08:56, Wang Nan wrote: > I hit following building error randomly: Random presumably because there is a race to use/create the directory by different make jobs (i.e. -j option). > > ... > /bin/sh: /path/to/kernel/buildperf/util/intel-pt-decoder/inat-tables.c: No such file or directory > ... > LINK /path/to/kernel/buildperf/plugin_mac80211.so > LINK /path/to/kernel/buildperf/plugin_kmem.so > LINK /path/to/kernel/buildperf/plugin_xen.so > LINK /path/to/kernel/buildperf/plugin_hrtimer.so > In file included from util/intel-pt-decoder/intel-pt-insn-decoder.c:25:0: > util/intel-pt-decoder/inat.c:24:25: fatal error: inat-tables.c: No such file or directory > #include "inat-tables.c" > ^ > compilation terminated. > make[4]: *** [/path/to/kernel/buildperf/util/intel-pt-decoder/intel-pt-insn-decoder.o] Error 1 > make[4]: *** Waiting for unfinished jobs.... > LINK /path/to/kernel/buildperf/plugin_function.so > > This is caused by tools/perf/util/intel-pt-decoder/Build that, it tries to > generate $(OUTPUT)util/intel-pt-decoder/inat-tables.c atomatically but > forget to ensure the existance of $(OUTPUT)util/intel-pt-decoder directory. > > This patch fixes it by adding $(call rule_mkdir) like other similar rules. > > Signed-off-by: Wang Nan > Cc: Arnaldo Carvalho de Melo > Cc: Adrian Hunter Looks ok to me. Jiri? > --- > tools/perf/util/intel-pt-decoder/Build | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tools/perf/util/intel-pt-decoder/Build b/tools/perf/util/intel-pt-decoder/Build > index 240730d..2386322 100644 > --- a/tools/perf/util/intel-pt-decoder/Build > +++ b/tools/perf/util/intel-pt-decoder/Build > @@ -4,6 +4,7 @@ inat_tables_script = util/intel-pt-decoder/gen-insn-attr-x86.awk > inat_tables_maps = util/intel-pt-decoder/x86-opcode-map.txt > > $(OUTPUT)util/intel-pt-decoder/inat-tables.c: $(inat_tables_script) $(inat_tables_maps) > + $(call rule_mkdir) > @$(call echo-cmd,gen)$(AWK) -f $(inat_tables_script) $(inat_tables_maps) > $@ || rm -f $@ > > $(OUTPUT)util/intel-pt-decoder/intel-pt-insn-decoder.o: util/intel-pt-decoder/inat.c $(OUTPUT)util/intel-pt-decoder/inat-tables.c >