From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753896AbbIAGmU (ORCPT ); Tue, 1 Sep 2015 02:42:20 -0400 Received: from szxga02-in.huawei.com ([119.145.14.65]:10513 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752693AbbIAGmT (ORCPT ); Tue, 1 Sep 2015 02:42:19 -0400 Message-ID: <55E54897.806@huawei.com> Date: Tue, 1 Sep 2015 14:41:27 +0800 From: "Wangnan (F)" User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Adrian Hunter , Jiri Olsa CC: , , , , Arnaldo Carvalho de Melo Subject: Re: [PATCH] perf tools: Fix random building error References: <1441087005-107540-1-git-send-email-wangnan0@huawei.com> <55E5448E.40001@intel.com> In-Reply-To: <55E5448E.40001@intel.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.111.66.109] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2015/9/1 14:24, Adrian Hunter wrote: > On 01/09/15 08:56, Wang Nan wrote: >> I hit following building error randomly: > Random presumably because there is a race to use/create the directory by > different make jobs (i.e. -j option). Yes, I use -j 160 :) >> ... >> /bin/sh: /path/to/kernel/buildperf/util/intel-pt-decoder/inat-tables.c: No such file or directory >> ... >> LINK /path/to/kernel/buildperf/plugin_mac80211.so >> LINK /path/to/kernel/buildperf/plugin_kmem.so >> LINK /path/to/kernel/buildperf/plugin_xen.so >> LINK /path/to/kernel/buildperf/plugin_hrtimer.so >> In file included from util/intel-pt-decoder/intel-pt-insn-decoder.c:25:0: >> util/intel-pt-decoder/inat.c:24:25: fatal error: inat-tables.c: No such file or directory >> #include "inat-tables.c" >> ^ >> compilation terminated. >> make[4]: *** [/path/to/kernel/buildperf/util/intel-pt-decoder/intel-pt-insn-decoder.o] Error 1 >> make[4]: *** Waiting for unfinished jobs.... >> LINK /path/to/kernel/buildperf/plugin_function.so >> >> This is caused by tools/perf/util/intel-pt-decoder/Build that, it tries to >> generate $(OUTPUT)util/intel-pt-decoder/inat-tables.c atomatically but >> forget to ensure the existance of $(OUTPUT)util/intel-pt-decoder directory. >> >> This patch fixes it by adding $(call rule_mkdir) like other similar rules. >> >> Signed-off-by: Wang Nan >> Cc: Arnaldo Carvalho de Melo >> Cc: Adrian Hunter > Looks ok to me. Jiri? > >> --- >> tools/perf/util/intel-pt-decoder/Build | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/tools/perf/util/intel-pt-decoder/Build b/tools/perf/util/intel-pt-decoder/Build >> index 240730d..2386322 100644 >> --- a/tools/perf/util/intel-pt-decoder/Build >> +++ b/tools/perf/util/intel-pt-decoder/Build >> @@ -4,6 +4,7 @@ inat_tables_script = util/intel-pt-decoder/gen-insn-attr-x86.awk >> inat_tables_maps = util/intel-pt-decoder/x86-opcode-map.txt >> >> $(OUTPUT)util/intel-pt-decoder/inat-tables.c: $(inat_tables_script) $(inat_tables_maps) >> + $(call rule_mkdir) >> @$(call echo-cmd,gen)$(AWK) -f $(inat_tables_script) $(inat_tables_maps) > $@ || rm -f $@ >> >> $(OUTPUT)util/intel-pt-decoder/intel-pt-insn-decoder.o: util/intel-pt-decoder/inat.c $(OUTPUT)util/intel-pt-decoder/inat-tables.c >>