From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755228AbbIAHlz (ORCPT ); Tue, 1 Sep 2015 03:41:55 -0400 Received: from mga11.intel.com ([192.55.52.93]:65054 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755117AbbIAHlx (ORCPT ); Tue, 1 Sep 2015 03:41:53 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.17,447,1437462000"; d="scan'208";a="795249605" Message-ID: <55E556BE.1020705@linux.intel.com> Date: Tue, 01 Sep 2015 10:41:50 +0300 From: Jarkko Nikula User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.7.0 MIME-Version: 1.0 To: Tan Jui Nee , broonie@kernel.org CC: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, mika.westerberg@linux.intel.com Subject: Re: [PATCH] spi: spi-pxa2xx: Check status register to determine if SSSR_TINT is disabled References: <1441074171-23265-1-git-send-email-jui.nee.tan@intel.com> In-Reply-To: <1441074171-23265-1-git-send-email-jui.nee.tan@intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/01/2015 05:22 AM, Tan Jui Nee wrote: > From: "Tan, Jui Nee" > > On Intel Baytrail, there is case when interrupt handler get called, no SPI > message is captured. The RX FIFO is indeed empty when RX timeout pending > interrupt (SSSR_TINT) happens. > > Use the BIOS version where both HSUART and SPI are on the same IRQ. Both > drivers are using IRQF_SHARED when calling the request_irq function. When > running two separate and independent SPI and HSUART application that > generate data traffic on both components, user will see messages like > below on the console: > > pxa2xx-spi pxa2xx-spi.0: bad message state in interrupt handler > > This commit will fix this by first checking Receiver Time-out Interrupt, > if it is disabled, ignore the request and return without servicing. > > Signed-off-by: Tan, Jui Nee > --- > drivers/spi/spi-pxa2xx.c | 4 ++++ > 1 file changed, 4 insertions(+) > Acked-by: Jarkko Nikula