From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755267AbbIAHmv (ORCPT <rfc822;w@1wt.eu>);
	Tue, 1 Sep 2015 03:42:51 -0400
Received: from mout.web.de ([212.227.17.11]:64968 "EHLO mout.web.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1754318AbbIAHmt (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 1 Sep 2015 03:42:49 -0400
Subject: Re: [PATCH 03/11] ocfs2: Less checks in ocfs2_rename() after error
 detection
References: <alpine.DEB.2.10.1402251840450.7035@hadrien>
 <530CF8FF.8080600@users.sourceforge.net>
 <alpine.DEB.2.02.1402252117150.2047@localhost6.localdomain6>
 <530DD06F.4090703@users.sourceforge.net>
 <alpine.DEB.2.02.1402262129250.2221@localhost6.localdomain6>
 <5317A59D.4@users.sourceforge.net> <5455FC05.4010606@users.sourceforge.net>
 <alpine.DEB.2.02.1411021150540.2239@localhost6.localdomain6>
 <55992DF0.5030205@users.sourceforge.net>
 <55993170.6060306@users.sourceforge.net> <20150706085414.GD28762@mwanda>
Cc: Dan Carpenter <dan.carpenter@oracle.com>, Joel Becker <jlbec@evilplan.org>,
        Mark Fasheh <mfasheh@suse.com>, LKML <linux-kernel@vger.kernel.org>,
        Julia Lawall <julia.lawall@lip6.fr>
To: ocfs2-devel@oss.oracle.com, kernel-janitors@vger.kernel.org
From: SF Markus Elfring <elfring@users.sourceforge.net>
X-Enigmail-Draft-Status: N1110
Message-ID: <55E556DF.9000301@users.sourceforge.net>
Date: Tue, 1 Sep 2015 09:42:23 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.2.0
MIME-Version: 1.0
In-Reply-To: <20150706085414.GD28762@mwanda>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-Provags-ID: V03:K0:WcqzYaeJBNIiNRh5hqz2Iyc/1cbYK22l0XwzvtF2SO+DUJgDMEN
 lDCXTggjYeO8VogbKX5RfiWrvft7h2alncgVqFqoQpqKGvks3pmVMsS9bGLt980uX+80HiG
 NRSZBBO+pjR/UNFKRhO/Pip/QukhbYVwthIGv6yuFjzSOsgJCTFD2QgPNI6K1JSypocInOe
 W1sOCW0hwY/r8241Tqr7Q==
X-UI-Out-Filterresults: notjunk:1;V01:K0:rpkB0tQC3r0=:3LYDse5KiSzX7Cdw61sSyy
 xpMIU3qD+E+v4WolMsGrG571Z0MKhkrUv1q7vzUXSvUqBsnSIkTWzukZBB8gPSykHmXCNwVgk
 dFdPwlXssXFQjTgyVPI/E0kkl1GR2gQp3RnsMYTff2swklg8BQX/e41Yl2BxmYt5r/Pew5VKj
 6BKB9ZdF346OkmX1UVRaBFmCLOhIMfPyvyQDAjben8W7M+hL6dIR+tejUW+KlWDVCg2018PtC
 dEwO1CbQQ1EWUjoK+FcOptbq7sQrnB42IELq+9fD4sgCnPDItDzMqEUYeDkAN29p/Y+7cyIwV
 6MinNjGkV4xxm1t6KU+oDBNJif0E0VfQuJwOoJTNwwdY8Y3E+RvNMg3SBtACK2n13PoBABky6
 Lo0uSycFDJbmkdq5oatiQCORSsIS3IHWOYP8KFW587MdR3pDLsgKdR3eQfktp8p+3nda22FNI
 1o1uynG9YMtBN9qr2QgQ5Wd3FtM30q0LUVp6BGaQTcKMq+Tg4iw0uMjojeUjp0Tkbrmmx5N5/
 0gW+42DFx+vcmfiy6QQF/c72Xr2fwCPGsLHMTMc2QEkGihwl64pYkwJqqoAcDfKU7fq/gppJF
 bcrJ/SJT/zopuJjfzEr1G9XNibJ8vsPphR7VSqCNddtvAhUMi6qlnxayWnCwrNDr6fpwB4EXU
 z+YnXzmqpoozFjYIHXf6Used6mF+Dy1+G/2iaEgpnLGFGrST4CqfwRI+sq6pwmjYnWoVhIegh
 xGIn5gfqS2LxsLVQVrfXdILfmH2aRbvypn4PBA==
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>> From: Markus Elfring <elfring@users.sourceforge.net>
>> Date: Sat, 4 Jul 2015 15:30:18 +0200
>>
>> Skip checks for a few variables in three error handling cases within
>> the ocfs2_rename() function by adjustment of a few jump targets
>> according to the Linux coding style convention.
>>
>> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> 
> I don't think this is an improvement.

How do you think about the other update suggestions from this patch series?

Would anybody like to contribute constructive comments so that further progress
can eventually be achieved for a corresponding source code review?

Regards,
Markus