From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753594AbbIANGJ (ORCPT <rfc822;w@1wt.eu>);
	Tue, 1 Sep 2015 09:06:09 -0400
Received: from mga11.intel.com ([192.55.52.93]:40208 "EHLO mga11.intel.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752900AbbIANGH (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 1 Sep 2015 09:06:07 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.17,448,1437462000"; 
   d="scan'208";a="636268612"
Subject: Re: commit 3c2e7f7de3 (KVM use NPT page attributes) causes boot
 failures
To: Markus Trippelsdorf <markus@trippelsdorf.de>,
        Ingo Molnar <mingo@kernel.org>
References: <20150831172453.GA5429@gmail.com> <20150901070856.GA430@x4>
 <20150901072741.GB20383@gmail.com> <20150901074449.GB430@x4>
 <20150901083856.GD25398@gmail.com> <20150901084444.GB421@x4>
 <20150901085627.GF6315@gmail.com> <20150901100417.GA424@x4>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
        linux-kernel@vger.kernel.org, Peter Zijlstra <a.p.zijlstra@chello.nl>,
        Thomas Gleixner <tglx@linutronix.de>,
        Andrew Morton <akpm@linux-foundation.org>,
        Mike Galbraith <efault@gmx.de>, Joerg Roedel <jroedel@suse.de>,
        Paolo Bonzini <pbonzini@redhat.com>, kvm@vger.kernel.org
From: Xiao Guangrong <guangrong.xiao@linux.intel.com>
Message-ID: <55E5A157.5040403@linux.intel.com>
Date: Tue, 1 Sep 2015 21:00:07 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.1.0
MIME-Version: 1.0
In-Reply-To: <20150901100417.GA424@x4>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org



On 09/01/2015 06:04 PM, Markus Trippelsdorf wrote:
> On 2015.09.01 at 10:56 +0200, Ingo Molnar wrote:
>>
>> * Markus Trippelsdorf <markus@trippelsdorf.de> wrote:
>>> As I wrote in my other reply. The boot failure is nondeterministic (boot
>>> succeeds roughly every sixth time). So the bisection and the patch is
>>> just bogus (,but the boot failure is real).
>>>
>>> Sorry.
>>
>> No problem. Please let us know if any of these commits does turn out to be the
>> culprit. (Which is always a possibility.)
>
> I'm pretty sure commit 3c2e7f7de3 is the culprit.
>
> commit 3c2e7f7de3240216042b61073803b61b9b3cfb22
> Author: Paolo Bonzini <pbonzini@redhat.com>
> Date:   Tue Jul 7 14:32:17 2015 +0200
>
>      KVM: SVM: use NPT page attributes
>
> I've booted ten times in a row successfully with the following patch:
>
> diff --git a/arch/x86/kvm/svm.c b/arch/x86/kvm/svm.c
> index 74d825716f4f..3190173a575f 100644
> --- a/arch/x86/kvm/svm.c
> +++ b/arch/x86/kvm/svm.c
> @@ -989,7 +989,7 @@ static __init int svm_hardware_setup(void)
>   	} else
>   		kvm_disable_tdp();
>
> -	build_mtrr2protval();
> +//	build_mtrr2protval();
>   	return 0;
>
>   err:
>
> Paolo, your commit causes nondeterministic boot failure on my machine.
> It sometimes crashes early with the following backtrace:
>

Did it trigger the BUG()/BUG_ON() in mtrr2protval()/fallback_mtrr_type()?
If yes, could you please print the actual value out?

BTW, you may change BUG() to WARN() to get the print info more easier.