From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753670AbbIAP3v (ORCPT ); Tue, 1 Sep 2015 11:29:51 -0400 Received: from lists.s-osg.org ([54.187.51.154]:33584 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752648AbbIAP3u (ORCPT ); Tue, 1 Sep 2015 11:29:50 -0400 Subject: Re: [RESEND PATCH 3/7] usb: phy: isp1301: Export I2C module alias information To: linux-kernel@vger.kernel.org References: <1440484277-32675-1-git-send-email-javier@osg.samsung.com> <1440484277-32675-4-git-send-email-javier@osg.samsung.com> Cc: Greg Kroah-Hartman , linux-usb@vger.kernel.org, Felipe Balbi From: Javier Martinez Canillas Message-ID: <55E5C468.7010507@osg.samsung.com> Date: Tue, 1 Sep 2015 17:29:44 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.0.1 MIME-Version: 1.0 In-Reply-To: <1440484277-32675-4-git-send-email-javier@osg.samsung.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Greg and Felipe, On 08/25/2015 08:31 AM, Javier Martinez Canillas wrote: > The I2C core always reports the MODALIAS uevent as "i2c: regardless if the driver was matched using the I2C id_table or the > of_match_table. So the driver needs to export the I2C table and this > be built into the module or udev won't have the necessary information > to auto load the correct module when the device is added. > > Signed-off-by: Javier Martinez Canillas > > --- > > drivers/usb/phy/phy-isp1301.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/usb/phy/phy-isp1301.c b/drivers/usb/phy/phy-isp1301.c > index 8a55b37d1a02..db68156568e6 100644 > --- a/drivers/usb/phy/phy-isp1301.c > +++ b/drivers/usb/phy/phy-isp1301.c > @@ -31,6 +31,7 @@ static const struct i2c_device_id isp1301_id[] = { > { "isp1301", 0 }, > { } > }; > +MODULE_DEVICE_TABLE(i2c, isp1301_id); > > static struct i2c_client *isp1301_i2c_client; > > Any comments about this patch? The first version was posted about a month ago and is very trivial. Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America