From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752816AbbIBBW6 (ORCPT ); Tue, 1 Sep 2015 21:22:58 -0400 Received: from szxga01-in.huawei.com ([58.251.152.64]:28328 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751776AbbIBBW5 (ORCPT ); Tue, 1 Sep 2015 21:22:57 -0400 Message-ID: <55E64F4B.60705@huawei.com> Date: Wed, 2 Sep 2015 09:22:19 +0800 From: "Wangnan (F)" User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Arnaldo Carvalho de Melo , Masami Hiramatsu CC: , , , , , Brendan Gregg , Daniel Borkmann , "David Ahern" , He Kuang , Jiri Olsa , Kaixu Xia , Namhyung Kim , Paul Mackerras , Peter Zijlstra Subject: Re: [PATCH 28/31] perf probe: Init symbol as kprobe References: <1440822125-52691-1-git-send-email-wangnan0@huawei.com> <1440822125-52691-29-git-send-email-wangnan0@huawei.com> <20150901201159.GE22331@redhat.com> In-Reply-To: <20150901201159.GE22331@redhat.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.111.66.109] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2015/9/2 4:11, Arnaldo Carvalho de Melo wrote: > Em Sat, Aug 29, 2015 at 04:22:02AM +0000, Wang Nan escreveu: >> Before this patch, add_perf_probe_events() init symbol maps only for >> uprobe if the first 'struct perf_probe_event' passed to it is a uprobe >> event. This is a trick because 'perf probe''s command line syntax >> constrains the first elements of the probe_event arrays must be kprobes >> if there is one kprobe there. >> >> However, with the incoming BPF uprobe support, that constrain is not >> hold since 'perf record' will also probe on k/u probes through BPF >> object, and is possible to pass an array with kprobe but the first >> element is uprobe. >> >> This patch init symbol maps for kprobes even if all of events are >> uprobes, because the extra cost should be small enough. > Masami, are you Ok with this one? I think he would be okay with it because it is his idea :) Please refer to: http://lkml.kernel.org/n/558E5F42.1060705@hitachi.com Thank you. > - Arnaldo > >> Signed-off-by: Wang Nan >> Cc: Alexei Starovoitov >> Cc: Brendan Gregg >> Cc: Daniel Borkmann >> Cc: David Ahern >> Cc: He Kuang >> Cc: Jiri Olsa >> Cc: Kaixu Xia >> Cc: Masami Hiramatsu >> Cc: Namhyung Kim >> Cc: Paul Mackerras >> Cc: Peter Zijlstra >> Cc: Zefan Li >> Cc: pi3orama@163.com >> Cc: Arnaldo Carvalho de Melo >> Link: http://lkml.kernel.org/n/1436445342-1402-39-git-send-email-wangnan0@huawei.com >> --- >> tools/perf/util/probe-event.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/tools/perf/util/probe-event.c b/tools/perf/util/probe-event.c >> index e720913..b94a8d7 100644 >> --- a/tools/perf/util/probe-event.c >> +++ b/tools/perf/util/probe-event.c >> @@ -2789,7 +2789,7 @@ int add_perf_probe_events(struct perf_probe_event *pevs, int npevs, >> { >> int i, ret; >> >> - ret = init_symbol_maps(pevs->uprobes); >> + ret = init_symbol_maps(false); >> if (ret < 0) >> return ret; >> >> -- >> 2.1.0