From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751280AbbIBFB5 (ORCPT ); Wed, 2 Sep 2015 01:01:57 -0400 Received: from mailout4.samsung.com ([203.254.224.34]:37917 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750760AbbIBFBy (ORCPT ); Wed, 2 Sep 2015 01:01:54 -0400 X-AuditID: cbfee68d-f79106d00000728c-4a-55e682c0421e Message-id: <55E682C0.6050204@samsung.com> Date: Wed, 02 Sep 2015 14:01:52 +0900 From: Jaehoon Chung User-Agent: Mozilla/5.0 (X11; Linux i686; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-version: 1.0 To: Heiko Stuebner , ulf.hansson@linaro.org, mturquette@baylibre.com, sboyd@codeaurora.org, jh80.chung@samsung.com Cc: Alexandru M Stan , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 5/8] mmc: dw_mmc: dt-binding: Add tuning related things References: <1441045446-30858-1-git-send-email-heiko@sntech.de> <1441045446-30858-6-git-send-email-heiko@sntech.de> In-reply-to: <1441045446-30858-6-git-send-email-heiko@sntech.de> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrIIsWRmVeSWpSXmKPExsWyRsSkUPdA07NQg4W3xCwaXkxitfj/6DWr xY1fbawWmx5fY7X42HOP1eLyrjlsFkf+9zNafHrwn9ni4ilXix9nulksjq8Nd+D2eH+jld1j dsNFFo/Lfb1MHneu7WHz2Lyk3qNvyypGj+3X5jF7fN4kF8ARxWWTkpqTWZZapG+XwJXR0rWc reCGRMWZM0tYGhg/CHcxcnJICJhInLp2mRXCFpO4cG89WxcjF4eQwApGid6L/9hhijbsmQOV mMUosebRMzaQhJDAA0aJtq2ZIDavgJbExc8bwRpYBFQlHtw/CWazCehIbP92nAnEFhUIkzgz o4MFol5Q4sfkeywgQ0UEWhklVj6YzwriMAucYZT41/cTqJuDQ1jAW2LJ8QgQU0igVOLL3HiQ Xk4BB4kN01YwgoSZBfQk7l/UAgkzC8hLbF7zlhlkioRAK4fEmZ4zrBD3CEh8m3yIBaReQkBW YtMBZoi/JCUOrrjBMoFRbBaSi2YhTJ2FZOoCRuZVjKKpBckFxUnpRYZ6xYm5xaV56XrJ+bmb GIExe/rfs94djLcPWB9iFOBgVOLhbUh8FirEmlhWXJl7iNEU6IiJzFKiyfnAxJBXEm9obGZk YWpiamxkbmmmJM6rKPUzWEggPbEkNTs1tSC1KL6oNCe1+BAjEwenVAOj7pt9l2cnNjM8U5be J3dK4mrk1pSAZUsDVUUYDhxuX57ov7bE9J5oXpjsbsEVp9mOBOdO9Wu9+2hf2tbEuvyUTrGY K+ef1X81/fUjen/dc/mmhc1RKi03y9LP+ugcnl3H6XPZb/UcswV3Ftq0HvYTDH33/kPlrVV8 XmfWuF0yl1b33udiYK6txFKckWioxVxUnAgA14ZRGdQCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupjleLIzCtJLcpLzFFi42I5/e+xoO6BpmehBo+fCFg0vJjEavH/0WtW ixu/2lgtNj2+xmrxseceq8XlXXPYLI7872e0+PTgP7PFxVOuFj/OdLNYHF8b7sDt8f5GK7vH 7IaLLB6X+3qZPO5c28PmsXlJvUffllWMHtuvzWP2+LxJLoAjqoHRJiM1MSW1SCE1Lzk/JTMv 3VbJOzjeOd7UzMBQ19DSwlxJIS8xN9VWycUnQNctMwfoTiWFssScUqBQQGJxsZK+HaYJoSFu uhYwjRG6viFBcD1GBmggYQ1jRkvXcraCGxIVZ84sYWlg/CDcxcjJISFgIrFhzxw2CFtM4sK9 9UA2F4eQwCxGiTWPnoElhAQeMEq0bc0EsXkFtCQuft7IDmKzCKhKPLh/EsxmE9CR2P7tOBOI LSoQJnFmRgcLRL2gxI/J91hAhooItDJKrHwwnxXEYRY4wyjxr+8nUDcHh7CAt8SS4xEgppBA qcSXufEgvZwCDhIbpq1gBAkzC+hJ3L+oBRJmFpCX2LzmLfMERqAjETbMQqiahaRqASPzKkaJ 1ILkguKk9FyjvNRyveLE3OLSvHS95PzcTYzgtPBMegfj4V3uhxgFOBiVeHgbEp+FCrEmlhVX 5h5ilOBgVhLh5dEFCvGmJFZWpRblxxeV5qQWH2I0BQbBRGYp0eR8YMrKK4k3NDYxM7I0Mje0 MDI2VxLnzWF/EiokkJ5YkpqdmlqQWgTTx8TBKdXAWDmj3JPrMXdob6/3oSNWNTJnZXfmOn62 39rmfnPtHs4kqzPPVOyd87+Ffo5c7LBpmtEKpXuVp39Mabi+Mmhqc0TRV9UXbuo/raZ+7l5v 9CLwYe0JjR9CP+YYrYndcP/ThztB+jWaTFKNXxhfqK+a8tmjWCjsxO+yHTzZzU9EO/Sa10ue PjPtvhJLcUaioRZzUXEiAF7oxNIhAwAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Heiko. On 09/01/2015 03:24 AM, Heiko Stuebner wrote: > From: Alexandru M Stan > > Add ciu_drv, ciu_sample clocks and default-sample-phase. This will later > be used by tuning code. As i know, ciu_drv and ciu_sample clocks are generated with "ciu" clock. But in these patch-set, ciu_drv and ciu_sample are controlled by clock framework. It's a little strange. Are there ciu_drv and ciu_sample clock on Rockchip? Best Regards, Jaehoon Chung > > We do not touch ciu_drive (and by extension define default-drive-phase). > Drive phase is mostly used to define minimum hold times, while one could > write some code to determine what phase meets the minimum hold time > (ex 10 degrees) this will not work with the current clock phase framework > (which floors angles, so we'll get 0 deg, and there's no way to know what > resolution the floors happen at). We assume that the default drive angles > set by the hardware are good enough. > > Signed-off-by: Alexandru M Stan > Signed-off-by: Heiko Stuebner > --- > Documentation/devicetree/bindings/mmc/synopsys-dw-mshc.txt | 14 ++++++++++---- > 1 file changed, 10 insertions(+), 4 deletions(-) > > diff --git a/Documentation/devicetree/bindings/mmc/synopsys-dw-mshc.txt b/Documentation/devicetree/bindings/mmc/synopsys-dw-mshc.txt > index 346c609..5edadc2 100644 > --- a/Documentation/devicetree/bindings/mmc/synopsys-dw-mshc.txt > +++ b/Documentation/devicetree/bindings/mmc/synopsys-dw-mshc.txt > @@ -42,11 +42,13 @@ Optional properties: > * clocks: from common clock binding: handle to biu and ciu clocks for the > bus interface unit clock and the card interface unit clock. > > -* clock-names: from common clock binding: Shall be "biu" and "ciu". > - If the biu clock is missing we'll simply skip enabling it. If the > - ciu clock is missing we'll just assume that the clock is running at > +* clock-names: from common clock binding: Shall be "biu", "ciu", "ciu_drv" and > + "ciu_sample". If the biu clock is missing we'll simply skip enabling it. > + If the ciu clock is missing we'll just assume that the clock is running at > clock-frequency. It is an error to omit both the ciu clock and the > - clock-frequency. > + clock-frequency. "ciu_drv" and "ciu_sample" are used to control the clock > + phases, "ciu_sample" is required for tuning high speed modes (if no other > + custom tuning method is defined). > > * clock-frequency: should be the frequency (in Hz) of the ciu clock. If this > is specified and the ciu clock is specified then we'll try to set the ciu > @@ -75,6 +77,10 @@ Optional properties: > * vmmc-supply: The phandle to the regulator to use for vmmc. If this is > specified we'll defer probe until we can find this regulator. > > +* default-sample-phase: The default phase to set ciu_sample at probing, low > + speeds or in case where all phases work at tuning time. If not specified > + 0 deg will be used. > + > Aliases: > > - All the MSHC controller nodes should be represented in the aliases node using >