From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754036AbbIBLEb (ORCPT ); Wed, 2 Sep 2015 07:04:31 -0400 Received: from mx2.suse.de ([195.135.220.15]:42024 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752622AbbIBLEa (ORCPT ); Wed, 2 Sep 2015 07:04:30 -0400 Subject: Re: [PATCH] xen: fix the check of e_pfn in xen_find_pfn_range To: zhenzhong.duan@oracle.com, LKML References: <55E6D4B8.6020402@oracle.com> Cc: david.vrabel@citrix.com, konrad.wilk@oracle.com, boris.ostrovsky@oracle.com From: Juergen Gross Message-ID: <55E6D7BA.9060206@suse.com> Date: Wed, 2 Sep 2015 13:04:26 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <55E6D4B8.6020402@oracle.com> Content-Type: text/plain; charset=gbk; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/02/2015 12:51 PM, Zhenzhong Duan wrote: > On some numa system, after dom0 up, we see below warning even if there are > enough pfn ranges could be used for remapping. > "Unable to find available pfn range, not remapping identity pages" > > Fix it to avoid getting a memory region of zero size in xen_find_pfn_range. > > Signed-off-by: Zhenzhong Duan Reviewed-by: Juergen Gross > --- > arch/x86/xen/setup.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/arch/x86/xen/setup.c b/arch/x86/xen/setup.c > index a3a7546..c11f6b2 100644 > --- a/arch/x86/xen/setup.c > +++ b/arch/x86/xen/setup.c > @@ -178,7 +178,7 @@ static unsigned long __init xen_find_pfn_range( > e_pfn = PFN_DOWN(entry->addr + entry->size); > > /* We only care about E820 after this */ > - if (e_pfn < *min_pfn) > + if (e_pfn <= *min_pfn) > continue; > > s_pfn = PFN_UP(entry->addr);