From: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
To: Lars-Peter Clausen <lars@metafoo.de>,
Daniel Baluta <daniel.baluta@intel.com>,
jic23@kernel.org, jlbec@evilplan.org, linux-iio@vger.kernel.org,
linux-fsdevel@vger.kernel.org
Cc: knaack.h@gmx.de, linux-kernel@vger.kernel.org,
octavian.purdila@intel.com, pebolle@tiscali.nl,
patrick.porlan@intel.com, adriana.reus@intel.com,
constantin.musca@intel.com, marten@intuitiveaerial.com,
cristina.opriceana@gmail.com, pmeerw@pmeerw.net, hch@lst.de,
viro@zeniv.linux.org.uk, akpm@linux-foundation.org
Subject: Re: [PATCH v7 4/5] iio: trigger: Introduce IIO hrtimer based trigger
Date: Wed, 02 Sep 2015 15:16:42 +0300 [thread overview]
Message-ID: <55E6E8AA.6070108@cogentembedded.com> (raw)
In-Reply-To: <55E46B45.8040909@metafoo.de>
Hi Lars,
On 31.08.2015 17:57, Lars-Peter Clausen wrote:
> On 08/17/2015 02:45 PM, Vladimir Barinov wrote:
>> Hello Daniel,
>>
>> I've verified that your hrtimer trigger works.
>>
>> I have minor suggestions.
>>
>> Will not it be useful to have ability to stop/start hrtimer polling
>> not only during attach/detach trigger.
>>
>> f.e. writing 0 to sampling_frequency will hrtimer_cancel
>> and writing any valid frequency will hrtimer_start.
> What's the use case for this?
Setting sampling frequency to 0 Hz.
I do agree that 0Hz is meaningless and the same effect
is achieved by removing trigger from iio device,
but having 0 Hz frequency could probably be more consecutive
for this trigger instead of returning EINVAL.
Regards,
Vladimir
next prev parent reply other threads:[~2015-09-02 12:16 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-10 22:42 [PATCH v7 0/5] Add initial configfs support for IIO Daniel Baluta
2015-08-10 22:42 ` [PATCH v7 1/5] configfs: Allow dynamic group (un)registration Daniel Baluta
2015-08-31 16:02 ` Lars-Peter Clausen
2015-08-10 22:42 ` [PATCH v7 2/5] iio: core: Introduce IIO configfs support Daniel Baluta
2015-08-10 22:42 ` [PATCH v7 3/5] iio: core: Introduce IIO software triggers Daniel Baluta
2015-08-17 11:31 ` Vladimir Barinov
2015-08-31 14:41 ` Lars-Peter Clausen
2015-08-10 22:42 ` [PATCH v7 4/5] iio: trigger: Introduce IIO hrtimer based trigger Daniel Baluta
2015-08-17 12:45 ` Vladimir Barinov
2015-08-17 12:49 ` Daniel Baluta
2015-08-31 14:57 ` Lars-Peter Clausen
2015-09-02 12:16 ` Vladimir Barinov [this message]
2015-08-31 15:13 ` Lars-Peter Clausen
2015-08-10 22:42 ` [PATCH v7 5/5] iio: Documentation: Add IIO configfs documentation Daniel Baluta
2015-08-17 12:01 ` Vladimir Barinov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55E6E8AA.6070108@cogentembedded.com \
--to=vladimir.barinov@cogentembedded.com \
--cc=adriana.reus@intel.com \
--cc=akpm@linux-foundation.org \
--cc=constantin.musca@intel.com \
--cc=cristina.opriceana@gmail.com \
--cc=daniel.baluta@intel.com \
--cc=hch@lst.de \
--cc=jic23@kernel.org \
--cc=jlbec@evilplan.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marten@intuitiveaerial.com \
--cc=octavian.purdila@intel.com \
--cc=patrick.porlan@intel.com \
--cc=pebolle@tiscali.nl \
--cc=pmeerw@pmeerw.net \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox