From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754516AbbIBMZR (ORCPT ); Wed, 2 Sep 2015 08:25:17 -0400 Received: from mail-pa0-f44.google.com ([209.85.220.44]:33418 "EHLO mail-pa0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754301AbbIBMZO (ORCPT ); Wed, 2 Sep 2015 08:25:14 -0400 Subject: Re: [PATCH 1/2] mmc: sdhci-pxav3: Fix tabbing issue To: Joe Perches References: <1441135454-6902-1-git-send-email-vaibhav.hiremath@linaro.org> <1441135454-6902-2-git-send-email-vaibhav.hiremath@linaro.org> <1441139486.12163.3.camel@perches.com> Cc: linux-mmc@vger.kernel.org, ulf.hansson@linaro.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org From: Vaibhav Hiremath Message-ID: <55E6EAA5.4030808@linaro.org> Date: Wed, 2 Sep 2015 17:55:09 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <1441139486.12163.3.camel@perches.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday 02 September 2015 02:01 AM, Joe Perches wrote: > On Wed, 2015-09-02 at 00:54 +0530, Vaibhav Hiremath wrote: >> There were some coding style issues where spaces have been used instead >> of tabs, for example, in macro definitions, alignment of function >> declarations/definitions, etc... >> >> This patch fixes all such occurrences in the code. >> And also use BIT for bit definitions. > > Please send 2 patches instead. > >> diff --git a/drivers/mmc/host/sdhci-pxav3.c b/drivers/mmc/host/sdhci-pxav3.c > [] >> @@ -128,7 +133,7 @@ static int mv_conf_mbus_windows(struct platform_device *pdev, >> } >> >> static int armada_38x_quirks(struct platform_device *pdev, >> - struct sdhci_host *host) >> + struct sdhci_host *host) > > This is not an improvement. > Missed to highlight one more point here, The kernel CodingStyle talks about indentation, pasting it below - ------- Outside of comments, documentation and except in Kconfig, spaces are never used for indentation. ------- But I see spaces are being used at lot of places :) Till now all the patches or drivers which I submitted, I never used spaces. :) Anyway, just wanted to highlight CodingStyle document here. Thanks, Vaibhav