From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754765AbbIBXsW (ORCPT <rfc822;w@1wt.eu>);
	Wed, 2 Sep 2015 19:48:22 -0400
Received: from mailout1.w1.samsung.com ([210.118.77.11]:37659 "EHLO
	mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753138AbbIBXsU (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 2 Sep 2015 19:48:20 -0400
X-AuditID: cbfec7f4-f79c56d0000012ee-7d-55e78ac13014
Subject: Re: [PATCHv4] ARM: exynos_defconfig: Enable CONFIG_LEDS_PWM for
 Odroid-XU3/XU4
To: Anand Moon <linux.amoon@gmail.com>, Russell King <linux@arm.linux.org.uk>,
        Kukjin Kim <kgene@kernel.org>,
        Javier Martinez Canillas <javier@osg.samsung.com>,
        Lukasz Majewski <l.majewski@samsung.com>,
        Andreas Faerber <afaerber@suse.de>
References: <1441212107-3993-1-git-send-email-linux.amoon@gmail.com>
Cc: linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org,
        linux-kernel@vger.kernel.org
From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Message-id: <55E78AC0.10006@samsung.com>
Date: Thu, 03 Sep 2015 08:48:16 +0900
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.2.0
MIME-version: 1.0
In-reply-to: <1441212107-3993-1-git-send-email-linux.amoon@gmail.com>
Content-type: text/plain; charset=windows-1252
Content-transfer-encoding: 7bit
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrILMWRmVeSWpSXmKPExsVy+t/xy7oHu56HGqzYJGHRvKnY4s3bNUwW
	r18YWvQ/fs1s8ebhZkaLTY+vsVpc3jWHzWLG+X1MFus23mK3uH2Z14HLo6W5h81j56y77B6b
	VnWyeWxeUu+xpR/I69uyitFj8+lqj8+b5AI4orhsUlJzMstSi/TtErgy/vcvYS5YyV3x/lcn
	YwPjUc4uRg4OCQETiVXLLLsYOYFMMYkL99azgdhCAksZJVacUu1i5AKyvzBKnNuxkh0kISwQ
	KdE7aS8LSEJE4DOjxNGXK9ghOlwk/s+azQQylFkgW2LLKyaQMJuAscTm5UvAhvIKaEg03p0N
	FmcRUJVYu/8nWFxUIELi1Nm3UDWCEj8m32MBsTkFXCVaNpxkhxipJ3H/ohZImFlAXmLzmrfM
	ExgFZiHpmIVQNQtJ1QJG5lWMoqmlyQXFSem5hnrFibnFpXnpesn5uZsYIRHxZQfj4mNWhxgF
	OBiVeHgbEp+FCrEmlhVX5h5ilOBgVhLhPVD/PFSINyWxsiq1KD++qDQntfgQozQHi5I479xd
	70OEBNITS1KzU1MLUotgskwcnFINjCJfpzx+cujOYkOec/+XvD2c2nxXq3nWPDmz/Z+3lW36
	fP7uXUERYc5WwxMxcjPOislIXPeNlfh+9fOqft9TWS1Gs5Z0ybEemzxlVczVMI0dcbm7fqYm
	yAafPxI5VT+ya0mPRzeXr/z57wKF50z6Zp6ZufNcgKSmYTb3v04JZxm3W8yXdp5WTVBiKc5I
	NNRiLipOBADl2DAVhAIAAA==
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 03.09.2015 01:41, Anand Moon wrote:
> Enable CONFIG_LEDS_PWM amd CONFIG_LEDS_TRIGGER_HEARTBEAT for
> Odroid-XU3/XU4 board.
> 
> Signed-off-by: Anand Moon <linux.amoon@gmail.com>
> 
> ---
> Changes from last version.
>   Make all modules build-in.
>   Enabled LEDS_GPIO
> ---
>  arch/arm/configs/exynos_defconfig | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/arch/arm/configs/exynos_defconfig b/arch/arm/configs/exynos_defconfig
> index 2263cd9..c285975 100644
> --- a/arch/arm/configs/exynos_defconfig
> +++ b/arch/arm/configs/exynos_defconfig
> @@ -168,6 +168,16 @@ CONFIG_MMC_SDHCI_S3C_DMA=y
>  CONFIG_MMC_DW=y
>  CONFIG_MMC_DW_IDMAC=y
>  CONFIG_MMC_DW_EXYNOS=y
> +CONFIG_NEW_LEDS=y
> +CONFIG_LEDS_CLASS=y
> +CONFIG_LEDS_CLASS_FLASH=y
> +CONFIG_LEDS_GPIO=y
> +CONFIG_LEDS_PWM=y
> +CONFIG_LEDS_TRIGGERS=y
> +CONFIG_LEDS_TRIGGER_TIMER=y
> +CONFIG_LEDS_TRIGGER_ONESHOT=y
> +CONFIG_LEDS_TRIGGER_HEARTBEAT=y
> +CONFIG_LEDS_TRIGGER_GPIO=y

This is getting boring. I asked about enabling LEDS_GPIO, which you
confirmed in changelog. Good!
So what are LEDS_CLASS_FLASH, TRIGGER_ONESHOT and TRIGGER_GPIO doing
here? They are not mentioned in commit message, changelog and previous
discussions.

Beside that commit message seems to be far away from the contents now...

Best regards,
Krzysztof


>  CONFIG_RTC_CLASS=y
>  CONFIG_RTC_DRV_MAX77686=y
>  CONFIG_RTC_DRV_MAX77802=y
>