From: Chanwoo Choi <cw00.choi@samsung.com>
To: Javier Martinez Canillas <javier@osg.samsung.com>,
linux-kernel@vger.kernel.org
Cc: MyungJoo Ham <myungjoo.ham@samsung.com>
Subject: Re: [RESEND PATCH 5/7] extcon: Export OF module alias information in missing drivers
Date: Thu, 03 Sep 2015 13:28:17 +0900 [thread overview]
Message-ID: <55E7CC61.4020407@samsung.com> (raw)
In-Reply-To: <1440484277-32675-6-git-send-email-javier@osg.samsung.com>
On 2015년 08월 25일 15:31, Javier Martinez Canillas wrote:
> The I2C core always reports the MODALIAS uevent as "i2c:<modalias>"
> regardless of the mechanism that was used to register the device
> (i.e: OF or board code) and the table that is used later to match
> the driver with the device (i.e: I2C id table or OF match table).
>
> So drivers needs to export the I2C id table and this be built into
> the module or udev won't have the necessary information to autoload
> the needed driver module when the device is added.
>
> But this means that OF-only drivers needs to have both OF and I2C id
> tables that have to be kept in sync and also the dev node compatible
> manufacturer prefix is stripped when reporting the MODALIAS. Which can
> lead to issues if two vendors use the same I2C device name for example.
>
> To avoid the above, the I2C core behavior may be changed in the future
> to not require an SPI device table for OF-only drivers and report the
> OF module alias. So, it's better to also export the OF table even when
> is unused now to prevent breaking module loading when the core changes.
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
>
> ---
>
> drivers/extcon/extcon-rt8973a.c | 1 +
> drivers/extcon/extcon-sm5502.c | 1 +
> 2 files changed, 2 insertions(+)
Applied it.
Thanks,
Chanwoo Choi
next prev parent reply other threads:[~2015-09-03 4:28 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-25 6:31 [RESEND PATCH 0/7] Export I2C and OF module aliases in missing drivers Javier Martinez Canillas
2015-08-25 6:31 ` [RESEND PATCH 1/7] i2c: core: Export I2C module alias information in dummy driver Javier Martinez Canillas
2015-08-26 16:55 ` Wolfram Sang
2015-08-26 18:09 ` Javier Martinez Canillas
2015-08-31 20:31 ` Wolfram Sang
2015-08-31 22:30 ` Javier Martinez Canillas
2015-08-31 22:46 ` Wolfram Sang
2015-08-25 6:31 ` [RESEND PATCH 2/7] backlight: tosa: Export I2C module alias information Javier Martinez Canillas
2015-08-25 7:32 ` Lee Jones
2015-08-25 6:31 ` [RESEND PATCH 3/7] usb: phy: isp1301: " Javier Martinez Canillas
2015-09-01 15:29 ` Javier Martinez Canillas
2015-09-09 23:38 ` Javier Martinez Canillas
2015-08-25 6:31 ` [RESEND PATCH 4/7] ALSA: ppc: keywest: " Javier Martinez Canillas
2015-08-25 10:19 ` Takashi Iwai
2015-08-25 6:31 ` [RESEND PATCH 5/7] extcon: Export OF module alias information in missing drivers Javier Martinez Canillas
2015-09-03 4:28 ` Chanwoo Choi [this message]
2015-08-25 6:31 ` [RESEND PATCH 6/7] leds: " Javier Martinez Canillas
2015-08-25 9:13 ` Jacek Anaszewski
2015-08-25 6:31 ` [RESEND PATCH 7/7] regulator: isl9305: Export OF module alias information Javier Martinez Canillas
2015-08-25 16:20 ` Mark Brown
2015-08-25 17:33 ` Javier Martinez Canillas
2015-08-25 18:01 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55E7CC61.4020407@samsung.com \
--to=cw00.choi@samsung.com \
--cc=javier@osg.samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox