From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756541AbbICE2W (ORCPT ); Thu, 3 Sep 2015 00:28:22 -0400 Received: from mailout1.samsung.com ([203.254.224.24]:59439 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754069AbbICE2T convert rfc822-to-8bit (ORCPT ); Thu, 3 Sep 2015 00:28:19 -0400 X-AuditID: cbfee691-f79ca6d00000456a-2c-55e7cc610cd3 MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 Content-transfer-encoding: 8BIT Message-id: <55E7CC61.4020407@samsung.com> Date: Thu, 03 Sep 2015 13:28:17 +0900 From: Chanwoo Choi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Javier Martinez Canillas , linux-kernel@vger.kernel.org Cc: MyungJoo Ham Subject: Re: [RESEND PATCH 5/7] extcon: Export OF module alias information in missing drivers References: <1440484277-32675-1-git-send-email-javier@osg.samsung.com> <1440484277-32675-6-git-send-email-javier@osg.samsung.com> In-reply-to: <1440484277-32675-6-git-send-email-javier@osg.samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprLIsWRmVeSWpSXmKPExsWyRsSkUDfxzPNQg5OHJS3evF3DZHF51xw2 i9uNK9gcmD229N9l9+jbsorR4/MmuQDmKC6blNSczLLUIn27BK6M31+2sxb84aqY/uIDUwPj DY4uRk4OCQETiR1TdrNC2GISF+6tZ+ti5OIQEljBKPFuYj8rTNGrB/fZIRKzGCXOzprLBJLg FRCU+DH5HguIzSygLjFp3iJmCFtEYv+hSawQtrbEsoWvmSGaHzBKPOvYAeRwADVrSXy9qABS wyKgKvH/5zywXjag8P4XN9hASkQFIiS6T1SChEUEQiX+XbzNCDPy1J2JYOXCAvESd7q+MUKM b2aUmPyhDayIU8Bd4uKaHWBHSwisYpfYuXsZM8QyAYlvkw+xgCyQEJCV2HSAGeJJSYmDK26w TGAUn4XktVlIXpuF5LVZSF5bwMiyilE0tSC5oDgpvchUrzgxt7g0L10vOT93EyMw1k7/ezZx B+P9A9aHGAU4GJV4eCfMfh4qxJpYVlyZe4jRFOiiicxSosn5wIjOK4k3NDYzsjA1MTU2Mrc0 UxLn1ZH+GSwkkJ5YkpqdmlqQWhRfVJqTWnyIkYmDU6qB8cjGxt8yx2vW65cpbpp6V4RT83IN Q69OR9ehhV4//BrsRLpn/P087+HX85XvX99dY3Fu55QK/ehOq/2nRFyvsBd9qc2Yv2c614Q9 OV9tg66lqAd3TFJvaq47F/n5l7bt5F17xPImZRy6xr3mmvjRXRP0Mr78KOzNS/ms8YNXxvVJ 78Q2I9sl65VYijMSDbWYi4oTAWuxp9ywAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrAIsWRmVeSWpSXmKPExsVy+t9jQd3EM89DDU7tFbF483YNk8XlXXPY LG43rmBzYPbY0n+X3aNvyypGj8+b5AKYoxoYbTJSE1NSixRS85LzUzLz0m2VvIPjneNNzQwM dQ0tLcyVFPISc1NtlVx8AnTdMnOANikplCXmlAKFAhKLi5X07TBNCA1x07WAaYzQ9Q0Jgusx MkADCWsYM1b+/Mlc8Iqr4tahG0wNjMc4uhg5OSQETCRePbjPDmGLSVy4t56ti5GLQ0hgFqPE 2VlzmUASvAKCEj8m32PpYuTgYBaQlzhyKRskzCygLjFp3iJmiPoHjBLPOnYwg9TwCmhJfL2o AFLDIqAq8f/nPGYQmw0ovP/FDTaQElGBCInuE5UgYRGBUIl/F28zQozUljh1ZyJYubBAvMSd rm+MEOObGSUmf2gDK+IUcJe4uGYH+wRGoCMRrpuFcN0sJNctYGRexSiRWpBcUJyUnmuYl1qu V5yYW1yal66XnJ+7iREcm8+kdjAe3OV+iFGAg1GJh3fC7OehQqyJZcWVuYcYJTiYlUR4D9QD hXhTEiurUovy44tKc1KLDzGaAv03kVlKNDkfmDbySuINjU3MjCyNzA0tjIzNlcR5ZVc+CxUS SE8sSc1OTS1ILYLpY+LglGpgjChzzeXYukzYhNN4X71gtuJqRyEns612dyonVMVKprtsPvF/ w5Kc93LPma+tLBAOmZS+8fphxV4m9RjHsgfJHAf3r7t4/ckjA+dJVr4J99cmHAgWOGU3VeNS m/FnZ8/6dUzv7Lxn7GLYtbTw3EmuUz/WbZqnKX168p235akmOtcseFynbtu9VImlOCPRUIu5 qDgRADu8JJbjAgAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2015년 08월 25일 15:31, Javier Martinez Canillas wrote: > The I2C core always reports the MODALIAS uevent as "i2c:" > regardless of the mechanism that was used to register the device > (i.e: OF or board code) and the table that is used later to match > the driver with the device (i.e: I2C id table or OF match table). > > So drivers needs to export the I2C id table and this be built into > the module or udev won't have the necessary information to autoload > the needed driver module when the device is added. > > But this means that OF-only drivers needs to have both OF and I2C id > tables that have to be kept in sync and also the dev node compatible > manufacturer prefix is stripped when reporting the MODALIAS. Which can > lead to issues if two vendors use the same I2C device name for example. > > To avoid the above, the I2C core behavior may be changed in the future > to not require an SPI device table for OF-only drivers and report the > OF module alias. So, it's better to also export the OF table even when > is unused now to prevent breaking module loading when the core changes. > > Signed-off-by: Javier Martinez Canillas > > --- > > drivers/extcon/extcon-rt8973a.c | 1 + > drivers/extcon/extcon-sm5502.c | 1 + > 2 files changed, 2 insertions(+) Applied it. Thanks, Chanwoo Choi