From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756574AbbICFCy (ORCPT ); Thu, 3 Sep 2015 01:02:54 -0400 Received: from mailout3.w1.samsung.com ([210.118.77.13]:51042 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752399AbbICFCw (ORCPT ); Thu, 3 Sep 2015 01:02:52 -0400 X-AuditID: cbfec7f4-f79c56d0000012ee-67-55e7d478e0e8 Subject: Re: [PATCH] ARM: exynos_defconfig: Make S3C2410_WATCHDOG as loadable module To: Anand Moon , Russell King , Kukjin Kim , Javier Martinez Canillas , Andreas Faerber , Lukasz Majewski References: <1441253429-3264-1-git-send-email-linux.amoon@gmail.com> Cc: linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org From: Krzysztof Kozlowski X-Enigmail-Draft-Status: N1110 Message-id: <55E7D478.2020200@samsung.com> Date: Thu, 03 Sep 2015 14:02:48 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-version: 1.0 In-reply-to: <1441253429-3264-1-git-send-email-linux.amoon@gmail.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrHLMWRmVeSWpSXmKPExsVy+t/xa7oVV56HGkyeoGXRvKnY4ujvAovX Lwwt+h+/ZrZ483Azo8Wmx9dYLS7vmsNmMeP8PiaLdRtvsVvcvszrwOXR0tzD5vH3+XUWj52z 7rJ7bFrVyeaxeUm9R9+WVYwem09Xe3zeJBfAEcVlk5Kak1mWWqRvl8CVsfpaI2vBW46K7itn 2BoYt7J3MXJySAiYSHTc/8AKYYtJXLi3nq2LkYtDSGApo8SrGX0sEM4XRom/K9cygVQJC4RJ HD/0kxEkISLwh1Hiw4nNYAkhAReJZfNARnFwMAtkS2x5BRZmEzCW2Lx8CRvEBjmJ3u5JLCA2 r4CWxO7378GuYBFQlTi4dQbYFaICERKnzr5lg6gRlPgx+R5YPaeAq8Sdc2tZIMbrSdy/qAUS ZhaQl9i85i3zBEbBWUg6ZiFUzUJStYCReRWjaGppckFxUnquoV5xYm5xaV66XnJ+7iZGSKx8 2cG4+JjVIUYBDkYlHt4Js5+HCrEmlhVX5h5ilOBgVhLhPVAPFOJNSaysSi3Kjy8qzUktPsQo zcGiJM47d9f7ECGB9MSS1OzU1ILUIpgsEwenVAPjwpa/bSuSFTr85BLPT1zA+njC6/4Dzqcf LuAtvzZh6byKNpkn6SE6Fw6YRJ1zl7JufnPcs/O5CrdBYoHlGpu/m9as6Y9ousWyriuP22D1 HZEsV7fdK/wWL5vzXO3hD6Zj8bnv/3VvW7DzjusJM33N0/5JUib2+XNyrUK2PK67kvP7/uLZ v2PvKbEUZyQaajEXFScCADmPkE+RAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03.09.2015 13:10, Anand Moon wrote: > S3C2410_WATCHDOG watchdog drivers should not be loaded automatically, > but only if a watchdog daemon is installed. First of all: why? Secondly: even as a module driver could be loaded automatically to match enabled device (it has MODULE_DEVICE_TABLE). In the same time loading it does not hurt - watchdog should be inactive: s3c2410-wdt 10060000.watchdog: watchdog inactive, reset disabled, irq disabled Best regards, Krzysztof > > Signed-off-by: Anand Moon > --- > arch/arm/configs/exynos_defconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/configs/exynos_defconfig b/arch/arm/configs/exynos_defconfig > index aaf7aa4..b5d382e 100644 > --- a/arch/arm/configs/exynos_defconfig > +++ b/arch/arm/configs/exynos_defconfig > @@ -101,7 +101,7 @@ CONFIG_CPU_THERMAL=y > CONFIG_THERMAL_EMULATION=y > CONFIG_EXYNOS_THERMAL=y > CONFIG_WATCHDOG=y > -CONFIG_S3C2410_WATCHDOG=y > +CONFIG_S3C2410_WATCHDOG=m > CONFIG_MFD_CROS_EC=y > CONFIG_MFD_CROS_EC_I2C=y > CONFIG_MFD_CROS_EC_SPI=y >