From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1756652AbbICFLN (ORCPT <rfc822;w@1wt.eu>);
	Thu, 3 Sep 2015 01:11:13 -0400
Received: from mailout1.w1.samsung.com ([210.118.77.11]:40667 "EHLO
	mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1756636AbbICFLL (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 3 Sep 2015 01:11:11 -0400
X-AuditID: cbfec7f4-f79c56d0000012ee-5d-55e7d66d1821
Subject: Re: [PATCHv5] ARM: exynos_defconfig: Enable LEDS for Odroid-XU3/XU4
To: Anand Moon <linux.amoon@gmail.com>, Russell King <linux@arm.linux.org.uk>,
        Kukjin Kim <kgene@kernel.org>,
        Javier Martinez Canillas <javier.martinez@collabora.co.uk>,
        Anand Moon <moon.linux@yahoo.com>, Andreas Faerber <afaerber@suse.de>,
        Lukasz Majewski <l.majewski@samsung.com>,
        Sjoerd Simons <sjoerd.simons@collabora.co.uk>
References: <1441252656-3034-1-git-send-email-linux.amoon@gmail.com>
Cc: linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org,
        linux-kernel@vger.kernel.org
From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Message-id: <55E7D66B.4060401@samsung.com>
Date: Thu, 03 Sep 2015 14:11:07 +0900
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.2.0
MIME-version: 1.0
In-reply-to: <1441252656-3034-1-git-send-email-linux.amoon@gmail.com>
Content-type: text/plain; charset=windows-1252
Content-transfer-encoding: 7bit
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpkkeLIzCtJLcpLzFFi42I5/e/4Nd3ca89DDY6/4rNo3lRscfR3gcXr
	F4YW/Y9fM1u8ebiZ0WLT42usFpd3zWGzmHF+H5PFuo232C1uX+a1uH5/GrPF9ONvWR14PFqa
	e9g8/j6/zuKxc9Zddo9NqzrZPDYvqffo27KK0WPz6WqPz5vkPGbNOswUwBnFZZOSmpNZllqk
	b5fAlXHyQhNbwUquio27dzE2MN7g6GLk5JAQMJFY8XQlC4QtJnHh3nq2LkYuDiGBpYwSBxYt
	ZoRwvjBKnOtvYAapEhbwkXh3+zErSEJE4BKTxIItDWDtQgIuErN7pgDZHBzMAtkSW14xgYTZ
	BIwlNi9fwgZi8wpoSbSd7GQEsVkEVCXWXT0EZosKREicOvsWqkZQ4sfke2AjOQVcJWYduc4E
	MVJP4v5FLZAws4C8xOY1b5knMArMQtIxC6FqFpKqBYzMqxhFU0uTC4qT0nMN9YoTc4tL89L1
	kvNzNzFCIubLDsbFx6wOMQpwMCrx8E6Y/TxUiDWxrLgy9xCjBAezkgjvgXqgEG9KYmVValF+
	fFFpTmrxIUZpDhYlcd65u96HCAmkJ5akZqemFqQWwWSZODilGhhNXv5a+m7779WBrmtWOfps
	f3IntPOpfM2c41fMss49jpEpcmKXXJA+/6CksLiqyKzkSSWL529j+9AgE2QZfPvm30snqpfV
	MOhJLHUVY3z28dWtg7d/PHxxXTR7lqtgzrOr+05r5ITlXmiMV775QShTxP2eT9LqsK/vL1z4
	fVDux6+Q652fPj/mVGIpzkg01GIuKk4EAGS+Gf6UAgAA
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 03.09.2015 12:57, Anand Moon wrote:
> From: Anand Moon <moon.linux@yahoo.com>
> 
> Enable config option NEW_LEDS, LEDS_CLASS, LEDS_GPIO, LEDS_PWM,
> LEDS_TRIGGERS, LEDS_TRIGGER_TIMER, LEDS_TRIGGER_HEARTBEAT for
> Odroid-XU3/XU4 board.
> 
> Signed-off-by: Anand Moon <linux.amoon@gmail.com>
> 
> ---
> Changes from last version
> dropped following option.
>   CONFIG_LEDS_CLASS_FLASH
>   CONFIG_TRIGGER_ONESHOT
>   CONFIG_TRIGGER_GPIO

Thank you. The patch looks good, commit message... almost. Now the
"From" address does not match "Signed-off-by".
Please fix and resubmit :) .

BR,
Krzysztof

> ---
>  arch/arm/configs/exynos_defconfig | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/arch/arm/configs/exynos_defconfig b/arch/arm/configs/exynos_defconfig
> index 9504e77..aaf7aa4 100644
> --- a/arch/arm/configs/exynos_defconfig
> +++ b/arch/arm/configs/exynos_defconfig
> @@ -163,6 +163,13 @@ CONFIG_MMC_SDHCI_S3C_DMA=y
>  CONFIG_MMC_DW=y
>  CONFIG_MMC_DW_IDMAC=y
>  CONFIG_MMC_DW_EXYNOS=y
> +CONFIG_NEW_LEDS=y
> +CONFIG_LEDS_CLASS=y
> +CONFIG_LEDS_GPIO=y
> +CONFIG_LEDS_PWM=y
> +CONFIG_LEDS_TRIGGERS=y
> +CONFIG_LEDS_TRIGGER_TIMER=y
> +CONFIG_LEDS_TRIGGER_HEARTBEAT=y
>  CONFIG_RTC_CLASS=y
>  CONFIG_RTC_DRV_MAX77686=y
>  CONFIG_RTC_DRV_MAX77802=y
>