From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754611AbbICG5k (ORCPT ); Thu, 3 Sep 2015 02:57:40 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:44421 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750703AbbICG5i (ORCPT ); Thu, 3 Sep 2015 02:57:38 -0400 MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 X-AuditID: cbfee68f-f793b6d000005f66-99-55e7ef60bf8b Content-transfer-encoding: 8BIT Message-id: <55E7EF60.7020806@samsung.com> Date: Thu, 03 Sep 2015 15:57:36 +0900 From: Chanwoo Choi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Hans de Goede , MyungJoo Ham Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] extcon: Fix attached value returned by is_extcon_changed References: <1440369336-15795-1-git-send-email-hdegoede@redhat.com> In-reply-to: <1440369336-15795-1-git-send-email-hdegoede@redhat.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmplkeLIzCtJLcpLzFFi42JZI2JSpJvw/nmowb7v8hZvjk9nsri8aw6b xe3GFWwWCzY+YnRg8Xi/7yqbR9+WVYwenzfJBTBHcdmkpOZklqUW6dslcGVMaD7HXrCMo+Lp mZIGxtNsXYycHBICJhJzjjaxQthiEhfurQeKc3EICaxglLg3ZxMTTNHcBfOZIBJLGSWm/ZrH DJLgFRCU+DH5HksXIwcHs4C8xJFL2SBhZgF1iUnzFjFD1D9glJh6qI0VpIZXQEti/2oNkBoW AVWJ/78XsYPYbCDhFzfYQEpEBSIkuk9UgoRFBAIkfp7qZ4eYbiHRvt8UJCws4Cvx6/MFFhBb SMBZ4tzmpWDHcAq4SCxsucUKslVCYB27xPHdz1ghVglIfJt8COxKCQFZiU0HmCG+kpQ4uOIG ywRGsVlIfpmF8MssJL8sYGRexSiaWpBcUJyUXmSsV5yYW1yal66XnJ+7iREYO6f/PevfwXj3 gPUhRgEORiUe3gmzn4cKsSaWFVfmHmI0BTpiIrOUaHI+MELzSuINjc2MLExNTI2NzC3NlMR5 F0r9DBYSSE8sSc1OTS1ILYovKs1JLT7EyMTBKdXA6L/ihnlzSOCJfZny8ayOb5oZv+Vxyc2W DJRa/8jqlvAbv5+cK543rkzdImtnxG+mX2jWfE3vRpJfWy9Hh32ZRf7RGfzFLlU7eD2b1i7m uK5z71K8sHj3A/+6wwsYcm4t2737561qWf0dZtfnqzdeCfu7oTds7YsX7wLnLtjK5Lpn7ocL h/9qK7EUZyQaajEXFScCAGXJD82YAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrEIsWRmVeSWpSXmKPExsVy+t9jAd2E989DDZ6vl7Z4c3w6k8XlXXPY LG43rmCzWLDxEaMDi8f7fVfZPPq2rGL0+LxJLoA5qoHRJiM1MSW1SCE1Lzk/JTMv3VbJOzje Od7UzMBQ19DSwlxJIS8xN9VWycUnQNctMwdonZJCWWJOKVAoILG4WEnfDtOE0BA3XQuYxghd 35AguB4jAzSQsIYxY0LzOfaCZRwVT8+UNDCeZuti5OSQEDCRmLtgPhOELSZx4d56oDgXh5DA UkaJab/mMYMkeAUEJX5MvsfSxcjBwSwgL3HkUjZImFlAXWLSvEXMEPUPGCWmHmpjBanhFdCS 2L9aA6SGRUBV4v/vRewgNhtI+MUNNpASUYEIie4TlSBhEYEAiZ+n+tkhpltItO83BQkLC/hK /Pp8gQXEFhJwlji3eSnYMZwCLhILW26xTmAUmIXktlkIt81CctsCRuZVjBKpBckFxUnpuYZ5 qeV6xYm5xaV56XrJ+bmbGMHx+UxqB+PBXe6HGAU4GJV4eCfMfh4qxJpYVlyZe4hRgoNZSYQ3 5Q1QiDclsbIqtSg/vqg0J7X4EKMp0HcTmaVEk/OBqSOvJN7Q2MTMyNLI3NDCyNhcSZxXduWz UCGB9MSS1OzU1ILUIpg+Jg5OqQbGNRnn2efqfbFZdmrC7sbGyymlU/bPqv6QeEu3h3tz8Ju6 E8cNfsbuNoldO++RT/qB5K6TRpFn2Y1MRbU2S6occ208cCV/84wlCmxTiq5/rfy24WSzQ8hF +/r0nz+VUtONfN/k/ZRaYD9poRLn5sd/lk+WqDNef3iG8M6t9vX3Z6etYb08tfF/phJLcUai oRZzUXEiAFHty0PlAgAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2015년 08월 24일 07:35, Hans de Goede wrote: > is_extcon_changed should only check the idx-th bit of new, not > the entirety of new when setting attached. > > This fixes extcon sending notifications that a cable was inserted when > it gets removed while another cable is still connected. > > Cc: stable@vger.kernel.org > Signed-off-by: Hans de Goede > --- > drivers/extcon/extcon.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/extcon/extcon.c b/drivers/extcon/extcon.c > index 43b57b0..c4698ce 100644 > --- a/drivers/extcon/extcon.c > +++ b/drivers/extcon/extcon.c > @@ -159,7 +159,7 @@ static int find_cable_index_by_name(struct extcon_dev *edev, const char *name) > static bool is_extcon_changed(u32 prev, u32 new, int idx, bool *attached) > { > if (((prev >> idx) & 0x1) != ((new >> idx) & 0x1)) { > - *attached = new ? true : false; > + *attached = ((new >> idx) & 0x1) ? true : false; > return true; > } > > Applied it. Thanks, Chanwoo Choi