From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753054AbbICJOR (ORCPT ); Thu, 3 Sep 2015 05:14:17 -0400 Received: from mga02.intel.com ([134.134.136.20]:40613 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752984AbbICJOL (ORCPT ); Thu, 3 Sep 2015 05:14:11 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.17,461,1437462000"; d="scan'208";a="796912592" Subject: Re: [PATCH v2 2/4] perf tests: make objdump disassemble zero blocks To: Jan Stancek References: <9dc2c2d6d0cf0b6d8b43799e6e21101a4f50d08d.1441181335.git.jstancek@redhat.com> Cc: linux-kernel@vger.kernel.org, acme@kernel.org, jolsa@kernel.org, dsahern@gmail.com, cjashfor@linux.vnet.ibm.com, fweisbec@gmail.com, mingo@kernel.org, namhyung@kernel.org, paulus@samba.org, a.p.zijlstra@chello.nl From: Adrian Hunter Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki, Business Identity Code: 0357606 - 4, Domiciled in Helsinki Message-ID: <55E80EBA.6080107@intel.com> Date: Thu, 3 Sep 2015 12:11:22 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <9dc2c2d6d0cf0b6d8b43799e6e21101a4f50d08d.1441181335.git.jstancek@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/09/15 11:19, Jan Stancek wrote: > Add -z parameter to avoid skipping zero blocks: > > ffffffff816704fe : > ffffffff816704fe: 7b 34 jnp ffffffff81670534 > ... > ffffffff81670501 : > ffffffff81670501: 0f ba e2 03 bt $0x3,%edx > ffffffff81670505: 73 11 jae ffffffff81670518 > > Signed-off-by: Jan Stancek > Cc: Arnaldo Carvalho de Melo > Cc: Jiri Olsa > Cc: Adrian Hunter > Cc: David Ahern > Cc: Corey Ashford > Cc: Frederic Weisbecker > Cc: Ingo Molnar > Cc: Namhyung Kim > Cc: Paul Mackerras > Cc: Peter Zijlstra Apart from nitpick below: Acked-by: Adrian Hunter > --- > tools/perf/tests/code-reading.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/tools/perf/tests/code-reading.c b/tools/perf/tests/code-reading.c > index 38ee90bc2228..375ba30e4ed0 100644 > --- a/tools/perf/tests/code-reading.c > +++ b/tools/perf/tests/code-reading.c > @@ -128,7 +128,8 @@ static int read_via_objdump(const char *filename, u64 addr, void *buf, > FILE *f; > int ret; > > - fmt = "%s -d --start-address=0x%"PRIx64" --stop-address=0x%"PRIx64" %s"; > + fmt = "%s -z -d --start-address=0x%"PRIx64\ The line continuation is not needed but we are not that religious about long lines especially if they contain string literals, so you could just make it one line. > + " --stop-address=0x%"PRIx64" %s"; > ret = snprintf(cmd, sizeof(cmd), fmt, "objdump", addr, addr + len, > filename); > if (ret <= 0 || (size_t)ret >= sizeof(cmd)) >