From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753191AbbICJPn (ORCPT ); Thu, 3 Sep 2015 05:15:43 -0400 Received: from mga11.intel.com ([192.55.52.93]:31990 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753140AbbICJPm (ORCPT ); Thu, 3 Sep 2015 05:15:42 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.17,461,1437462000"; d="scan'208";a="796913309" Subject: Re: [PATCH v2 4/4] perf tests: print objdump/dso buffers if they don't match To: Jan Stancek References: Cc: linux-kernel@vger.kernel.org, acme@kernel.org, jolsa@kernel.org, dsahern@gmail.com, cjashfor@linux.vnet.ibm.com, fweisbec@gmail.com, mingo@kernel.org, namhyung@kernel.org, paulus@samba.org, a.p.zijlstra@chello.nl From: Adrian Hunter Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki, Business Identity Code: 0357606 - 4, Domiciled in Helsinki Message-ID: <55E80F15.7000304@intel.com> Date: Thu, 3 Sep 2015 12:12:53 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/09/15 11:19, Jan Stancek wrote: > Signed-off-by: Jan Stancek > Cc: Arnaldo Carvalho de Melo > Cc: Jiri Olsa > Cc: Adrian Hunter > Cc: David Ahern > Cc: Corey Ashford > Cc: Frederic Weisbecker > Cc: Ingo Molnar > Cc: Namhyung Kim > Cc: Paul Mackerras > Cc: Peter Zijlstra Acked-by: Adrian Hunter > --- > tools/perf/tests/code-reading.c | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > > diff --git a/tools/perf/tests/code-reading.c b/tools/perf/tests/code-reading.c > index e6bf47ff7e91..53a04f899d18 100644 > --- a/tools/perf/tests/code-reading.c > +++ b/tools/perf/tests/code-reading.c > @@ -163,6 +163,18 @@ static int read_via_objdump(const char *filename, u64 addr, void *buf, > return ret; > } > > +static void dump_buf(unsigned char *buf, size_t len) > +{ > + size_t i; > + > + for (i = 0; i < len; i++) { > + pr_debug("0x%02x ", buf[i]); > + if (i % 16 == 15) > + pr_debug("\n"); > + } > + pr_debug("\n"); > +} > + > static int read_object_code(u64 addr, size_t len, u8 cpumode, > struct thread *thread, struct state *state) > { > @@ -265,6 +277,10 @@ static int read_object_code(u64 addr, size_t len, u8 cpumode, > /* The results should be identical */ > if (memcmp(buf1, buf2, len)) { > pr_debug("Bytes read differ from those read by objdump\n"); > + pr_debug("buf1 (dso):\n"); > + dump_buf(buf1, len); > + pr_debug("buf2 (objdump):\n"); > + dump_buf(buf2, len); > return -1; > } > pr_debug("Bytes read match those read by objdump\n"); >