From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753472AbbICJdk (ORCPT ); Thu, 3 Sep 2015 05:33:40 -0400 Received: from mx-rz-3.rrze.uni-erlangen.de ([131.188.11.22]:50000 "EHLO mx-rz-3.rrze.uni-erlangen.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752775AbbICJdi (ORCPT ); Thu, 3 Sep 2015 05:33:38 -0400 X-Greylist: delayed 578 seconds by postgrey-1.27 at vger.kernel.org; Thu, 03 Sep 2015 05:33:37 EDT X-RRZE-Submit-IP: 2001:638:a000:4142::ff0f:d304 Message-ID: <55E811AB.6070002@fau.de> Date: Thu, 03 Sep 2015 11:23:55 +0200 From: Andreas Ziegler User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: Helge Deller CC: linux-parisc@vger.kernel.org, Valentin Rothberg , Paul Bolle , linux-kernel , John David Anglin Subject: Re: parisc: adjust L1_CACHE_BYTES to 128 bytes on PA8800 and PA8900 CPUs Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Helge, today's linux-next tree (next-20150903) contains commit 20f924902ff6 ("parisc: adjust L1_CACHE_BYTES to 128 bytes on PA8800 and PA8900 CPUs") which you authored. I noticed it because we[0] are running a daily analysis on all commits in linux-next as part of our research and our tools reported it. In the patch, you create the following #if defined() structure in arch/parisc/include/asm/cache.h (lines 16 and following): #if defined(CONFIG_PA8X00) ... #elif defined(CONFIG_PA20) ... #else ... #endif In Kconfig, CONFIG_PA20 is defined as the following (arch/parisc/Kconfig, line 163): config PA20 def_bool y depends on PA8X00 This means that CONFIG_PA20 can and will only be enabled if CONFIG_PA8X00 has already been enabled, which means that the contents of the "#elif defined(CONFIG_PA20)" block can never be reached: its condition is only evaluated if CONFIG_PA8X00 is disabled, but then CONFIG_PA20 can never be enabled either. Best regards, Andreas [0] https://cados.cs.fau.de