From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754196AbbICLEd (ORCPT ); Thu, 3 Sep 2015 07:04:33 -0400 Received: from mga02.intel.com ([134.134.136.20]:62777 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752877AbbICLEc (ORCPT ); Thu, 3 Sep 2015 07:04:32 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.17,461,1437462000"; d="scan'208";a="796961922" Subject: Re: [PATCH V2 0/7] x86/insn: perf tools: Add a few new x86 instructions To: Arnaldo Carvalho de Melo References: <1441196131-20632-1-git-send-email-adrian.hunter@intel.com> <20150902195408.GA11521@kernel.org> Cc: linux-kernel@vger.kernel.org, Jiri Olsa , Andy Lutomirski , Masami Hiramatsu , Denys Vlasenko , Peter Zijlstra , Ingo Molnar , Dave Hansen , Qiaowei Ren , "H. Peter Anvin" , Thomas Gleixner From: Adrian Hunter Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki, Business Identity Code: 0357606 - 4, Domiciled in Helsinki Message-ID: <55E82896.7080901@intel.com> Date: Thu, 3 Sep 2015 14:01:42 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <20150902195408.GA11521@kernel.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/09/15 22:54, Arnaldo Carvalho de Melo wrote: > Em Wed, Sep 02, 2015 at 03:15:24PM +0300, Adrian Hunter escreveu: >> Changes in V2: >> >> perf tools: Display build warning if x86 instruction decoder differs from kernel >> New patch (slightly modified from the proposal and so without Jiri's Ack) > > Applied. Thank you! > > But please consider doing some extra work on at least showing > what are the difference. > > I think those diff calls should be moved to a separate shell script, > that would either do what they do now, i.e. show that one line "things > changed!" or would produce a diff file that would then have its contents > shown, this way one could go on removing such differences, building > again, rinse, repeat, till the warning is gone. OK