From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754333AbbICLiT (ORCPT ); Thu, 3 Sep 2015 07:38:19 -0400 Received: from mga09.intel.com ([134.134.136.24]:13034 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753919AbbICLiS (ORCPT ); Thu, 3 Sep 2015 07:38:18 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.17,461,1437462000"; d="scan'208";a="781859446" Subject: Re: [PATCH v3 1/4] perf tests: take into account address of each objdump line To: Jan Stancek References: <55E80DFA.7090609@intel.com> <786600d67e80b0b0229a4eb16134244b23783c43.1441275982.git.jstancek@redhat.com> Cc: linux-kernel@vger.kernel.org, acme@kernel.org, jolsa@kernel.org, dsahern@gmail.com, cjashfor@linux.vnet.ibm.com, fweisbec@gmail.com, mingo@kernel.org, namhyung@kernel.org, paulus@samba.org, a.p.zijlstra@chello.nl From: Adrian Hunter Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki, Business Identity Code: 0357606 - 4, Domiciled in Helsinki Message-ID: <55E83081.5030102@intel.com> Date: Thu, 3 Sep 2015 14:35:29 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <786600d67e80b0b0229a4eb16134244b23783c43.1441275982.git.jstancek@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/09/15 14:23, Jan Stancek wrote: > objdump output can contain repeated bytes. At the moment test reads > all output sequentially, assuming each address is represented in > output only once: > > ffffffff8164efb3 : > ffffffff8164efb3: c1 5d 00 eb rcrl $0xeb,0x0(%rbp) > ffffffff8164efb7: 00 4c 8b 5c add %cl,0x5c(%rbx,%rcx,4) > > ffffffff8164efb8 : > ffffffff8164efb8: 4c 8b 5c 24 30 mov 0x30(%rsp),%r11 > ffffffff8164efbd: 4c 8b 54 24 38 mov 0x38(%rsp),%r10 > > Store objdump output to buffer according to offset calculated > from address on each line. > > Signed-off-by: Jan Stancek > Cc: Arnaldo Carvalho de Melo > Cc: Jiri Olsa > Cc: Adrian Hunter > Cc: David Ahern > Cc: Corey Ashford > Cc: Frederic Weisbecker > Cc: Ingo Molnar > Cc: Namhyung Kim > Cc: Paul Mackerras > Cc: Peter Zijlstra > --- > tools/perf/tests/code-reading.c | 53 +++++++++++++++++++++++++++++++---------- > 1 file changed, 40 insertions(+), 13 deletions(-) > > Changes in v3: > align read_objdump_line parameters on 2nd line > fix multiline comment > replace MIN with min > Acked-by: Adrian Hunter