From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754161AbbICLq5 (ORCPT <rfc822;w@1wt.eu>);
	Thu, 3 Sep 2015 07:46:57 -0400
Received: from mout.web.de ([212.227.15.3]:54241 "EHLO mout.web.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753881AbbICLqy (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Thu, 3 Sep 2015 07:46:54 -0400
Subject: Re: [Cocci] [RFC] firmware: annotate thou shalt not request fw on
 init or probe
To: "Luis R. Rodriguez" <mcgrof@do-not-panic.com>,
        Julia Lawall <julia.lawall@lip6.fr>
References: <1440811107-861-1-git-send-email-mcgrof@do-not-panic.com>
Cc: Alessandro Rubini <rubini@gnudd.com>,
        Alexander Viro <viro@zeniv.linux.org.uk>,
        David Woodhouse <dwmw2@infradead.org>,
        Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Jie Yang <yang.jie@intel.com>, Jiri Slaby <jslaby@suse.com>,
        Jonathan Corbet <corbet@lwn.net>,
        Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
        Kay Sievers <kay@vrfy.org>, Kevin Cernekee <cernekee@gmail.com>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Michal Marek <mmarek@suse.com>, Ming Lei <ming.lei@canonical.com>,
        Takashi Iwai <tiwai@suse.de>, Tom Gundersen <teg@jklm.no>,
        Yalin Wang <yalin.wang2010@gmail.com>,
        Coccinelle <cocci@systeme.lip6.fr>, linux-doc@vger.kernel.org,
        linux-serial@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
From: SF Markus Elfring <elfring@users.sourceforge.net>
X-Enigmail-Draft-Status: N1110
Message-ID: <55E832EE.7050801@users.sourceforge.net>
Date: Thu, 3 Sep 2015 13:45:50 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.2.0
MIME-Version: 1.0
In-Reply-To: <1440811107-861-1-git-send-email-mcgrof@do-not-panic.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-Provags-ID: V03:K0:oF99BcIyLNLzUAoFl7gXSeScmiaDVgux6eKgNZFMeEUQJeg8Dy2
 HlmQr773pie6bg3iQIMgsen7MmBg3dcMHGm/aTnm1VcQ0vcc+9KysCYiMdogBQp1fE0TzWc
 g5ZfasRsOCkOD0gQmChyoOhMs+BEJzGG5+WYQnHrSqtpDROfxqIpUNLsq5QTMkWuSUc1XY/
 J40i+z3muvc9EsXe+BhTg==
X-UI-Out-Filterresults: notjunk:1;V01:K0:+ZfgXzVpMTA=:f0nqX3pQSnA7lb1NA9xjuN
 cmGsB+pJgaL+APF77MmxXLy3s9HbL/oNkAwEg3veUj5XMASTnyioR2JnO4Cql4xMWeoBmhQWq
 n0uL6lqCe/21UrBUZPHBsZs9H3nAXtYB2xhPHtuGpdIwTSutSPQGLvTiw63YIrNJCBCkoqD8l
 2B3FEt5z73QGPHI/zJPfnhIC86EniXtRPwmnnyvcEbwTsCUcL4l+lhH3KmdfxercmdR3Id1Fu
 QznEOlkBUFtsZoQFqB6n+0B6mv8o3ATlngEUzFfxIFGeHYG9cXUqmL/Xx0i0rZM/3+LnNhYcP
 EotCma3eBDBOWL6sHF1X0IjmCdWtjydH1z+yZPbkPCq2t2Yg/ZGeH2iurrr+/YhVHjJZvAswt
 r7pkxFl3oJF3uOMJt614+dd7zLydUkYZKHtXMx3tQMJ6BlG0zJj9RtzpSiPzIddMnaOxlcIKU
 +kj7WkKTo+FtJjyROzqhPqCn0MJLqdVZm5ejk7SrclOGvyNKDBeUDIvnY0RDR3zt6ij2d+SkF
 3lFcaeIiJGtG5zd6WBT9R/lZwIrgjZr2YRBdYIaQDZqOjKN88Hir3wb/fjxVsczxNhuXmD8mr
 b5qct65LkeTGbgMC7VSYG3OGcMqc+XRX2cNfiktYVKNcQPVvkZAVM1G6BtdAgxB8VCkIyJNQZ
 b+m+gLl9ko3ShJi73quVE8evt4g+JsagOFlBVQt0BBHumGKtryziWIHOY2q7jHraifxPZ1uKN
 NYRDO8DcDyt6AjvV0/1YYF963Rx9zLggfp+x0A==
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> +@ calls_fw_on_init depends on defines_module_init @
> +identifier defines_module_init.init;
> +position p1;
> +@@
> +
> +init(void)
> +{
> + ...

Would it make sense to use the specification "when any"
for such a SmPL ellipsis?
http://coccinelle.lip6.fr/docs/main_grammar004.html


> +(
> +request_firmware@p1(...)
> +|
> +request_firmware_nowait@p1(...)
> +|
> +request_firmware_direct@p1(...)
> +)
> +...
> +}


Are there any more source code variants to check today?

Regards,
Markus