From: Guenter Roeck <linux@roeck-us.net>
To: Luis de Bethencourt <luis@debethencourt.com>,
linux-kernel@vger.kernel.org
Cc: Wim Van Sebroeck <wim@iguana.be>,
linux-watchdog@vger.kernel.org,
Javier Martinez Canillas <javier@osg.samsung.com>
Subject: Re: [PATCH 1/3] watchdog: mach-moxart: Fix module autoload for OF platform driver
Date: Thu, 03 Sep 2015 08:24:20 -0700 [thread overview]
Message-ID: <55E86624.4000403@roeck-us.net> (raw)
In-Reply-To: <20150903110609.GA17390@goodgumbo.baconseed.org>
On 09/03/2015 04:06 AM, Luis de Bethencourt wrote:
> This platform driver has a OF device ID table but the OF module
> alias information is not created so module autoloading won't work.
>
> Signed-off-by: Luis de Bethencourt <luis@debethencourt.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/watchdog/moxart_wdt.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/watchdog/moxart_wdt.c b/drivers/watchdog/moxart_wdt.c
> index 2789da2..60b0605 100644
> --- a/drivers/watchdog/moxart_wdt.c
> +++ b/drivers/watchdog/moxart_wdt.c
> @@ -168,6 +168,7 @@ static const struct of_device_id moxart_watchdog_match[] = {
> { .compatible = "moxa,moxart-watchdog" },
> { },
> };
> +MODULE_DEVICE_TABLE(of, moxart_watchdog_match);
>
> static struct platform_driver moxart_wdt_driver = {
> .probe = moxart_wdt_probe,
>
prev parent reply other threads:[~2015-09-03 15:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-03 11:06 [PATCH 1/3] watchdog: mach-moxart: Fix module autoload for OF platform driver Luis de Bethencourt
2015-09-03 15:24 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55E86624.4000403@roeck-us.net \
--to=linux@roeck-us.net \
--cc=javier@osg.samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=luis@debethencourt.com \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox