From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933411AbbICP63 (ORCPT ); Thu, 3 Sep 2015 11:58:29 -0400 Received: from mail-wi0-f171.google.com ([209.85.212.171]:33129 "EHLO mail-wi0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933178AbbICPqH (ORCPT ); Thu, 3 Sep 2015 11:46:07 -0400 Message-ID: <55E86B31.3010604@linaro.org> Date: Thu, 03 Sep 2015 16:45:53 +0100 From: Srinivas Kandagatla User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Stephen Boyd CC: agross@codeaurora.org, linux-arm-msm@vger.kernel.org, Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Russell King , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/6] ARM: dts: ifc6410: Add pwrseq support for WLAN References: <1439903069-19752-1-git-send-email-srinivas.kandagatla@linaro.org> <1439903212-19931-1-git-send-email-srinivas.kandagatla@linaro.org> <55DCDF19.4070901@codeaurora.org> In-Reply-To: <55DCDF19.4070901@codeaurora.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 25/08/15 22:33, Stephen Boyd wrote: > On 08/18/2015 06:06 AM, Srinivas Kandagatla wrote: >> @@ -10,6 +11,20 @@ >> serial1 = &gsbi6_serial; >> }; >> + pwrseq { >> + #address-cells = <1>; >> + #size-cells = <1>; >> + ranges; > > Why do we need any of these three properties? > Yep, you are right I will remove it and give it a try. >> + compatible = "simple-bus"; >> + >> + sdcc4_pwrseq: sdcc4_pwrseq { >> + pinctrl-names = "default"; >> + pinctrl-0 = <&wlan_default_gpios>; >> + compatible = "mmc-pwrseq-simple"; >> + reset-gpios = <&pm8921_gpio 43 GPIO_ACTIVE_LOW>; > > Especially because this node doesn't have a reg property. >