From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756218AbbICSpN (ORCPT ); Thu, 3 Sep 2015 14:45:13 -0400 Received: from mout.gmx.net ([212.227.17.21]:55838 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751093AbbICSpK (ORCPT ); Thu, 3 Sep 2015 14:45:10 -0400 Subject: Re: parisc: adjust L1_CACHE_BYTES to 128 bytes on PA8800 and PA8900 CPUs To: Andreas Ziegler References: <55E811AB.6070002@fau.de> Cc: linux-parisc@vger.kernel.org, Valentin Rothberg , Paul Bolle , linux-kernel , John David Anglin From: Helge Deller Message-ID: <55E8952E.4080603@gmx.de> Date: Thu, 3 Sep 2015 20:45:02 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <55E811AB.6070002@fau.de> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:oRJssHAZLza0w4SWvHydUsYUaSuzFpmd6hJ0oSA5aKxiQj0zWeu /qW1TQZw6BVYqJR2c4DTPvm+9syO7B9o1N7MLxCSx9xeHGaLqhkLRWvYcTdSOcUtvTe9jSO plEGUIy9PVTTqsTCja9m+JblQ1VjIuIKdORvxOlwMbw8Z75oYb9SQA+U16LqeoHQ8sL6mMh l6AwTgcmzIdrXJ2CaHgBg== X-UI-Out-Filterresults: notjunk:1;V01:K0:d/14H4DlBnw=:UdOkWnNoHULWY0B66feQ3G q/SX2C9PVBTTVRS0qt0pFZtR8/nZ9N5vLUb/akPp/GW0eEQSeMCSUanCj0tu87cJ0qvEPvnxv hWuNSbSe3rvh17kzMY/MvrXN9zetKE6Zk8m+3ZthbwcXhHBYGgdXk1j3vZ3i09ZszUoIS+gl5 7FnrKFVoFyMTHHMaTkuKkTCmxQ7xjviqHLaElQ7GWHsjtdPDd4Q71sedyUjMa7rooHdzVYMc/ Ix8er6ZBybCqGZFMfykqDkT+m4wrRSAXC+fJBum7m4mDJT8b+vBndploGtkPqXxfN/OQeRGg8 67kD77BbxXz5uFPJB3/c/dq4BCZr6AJrc1gcW+NnOLpiUdbnIPrYgLxsUo09YiQAog5RC1Wna NGXgNN7q1sM4Q+3HBb0cDRpXSQROj5I8tDxZU7wQG2KLlNP29pp9kXE5VLSokTUJutdF2HOMJ +ltD6XpyiRamdxrORRCistc8UFcHiW1TzcYLv23S6rEdXvvgw7X+h28lTDTj1EjjEan4WJUmP Ex/Lfc+xX+9ec6KuzXxgr5J/TCBz1ZTbypZvoxXuctlEf4GnJb1Li4xv9wMt9i73NU66/yDhq bNw+pB91vgwZ+V3QeMS6kqMwRHr1ByrzNQCzA7SaoBKGWFas+qUTc3FR9IL06aagERWo4mKT3 BZzMuAYtePTZbTe+0HyA/meC1xJBbexzV/7zOsuaVs/togYok/Zo/RrCupqNMR9B/WGw+7YmK NsC8+hRWTQFTy+PFA+5e7mUPp51KL7pTWNbhog== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Andreas, On 03.09.2015 11:23, Andreas Ziegler wrote: > today's linux-next tree (next-20150903) contains commit 20f924902ff6 > ("parisc: adjust L1_CACHE_BYTES to 128 bytes on PA8800 and PA8900 CPUs") > which you authored. > > I noticed it because we[0] are running a daily analysis on all commits > in linux-next as part of our research and our tools reported it. > > In the patch, you create the following #if defined() structure in > arch/parisc/include/asm/cache.h (lines 16 and following): > > #if defined(CONFIG_PA8X00) > ... > #elif defined(CONFIG_PA20) > ... > #else > ... > #endif > > In Kconfig, CONFIG_PA20 is defined as the following > (arch/parisc/Kconfig, line 163): > > config PA20 > def_bool y > depends on PA8X00 > > This means that CONFIG_PA20 can and will only be enabled if > CONFIG_PA8X00 has already been enabled, which means that the contents of > the "#elif defined(CONFIG_PA20)" block can never be reached: its > condition is only evaluated if CONFIG_PA8X00 is disabled, but then > CONFIG_PA20 can never be enabled either. That's absolutely true. I'll fix it with the next iteration of this patch. Thanks, Helge