From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758332AbbIDIvB (ORCPT ); Fri, 4 Sep 2015 04:51:01 -0400 Received: from mail-wi0-f179.google.com ([209.85.212.179]:35070 "EHLO mail-wi0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758232AbbIDIu5 (ORCPT ); Fri, 4 Sep 2015 04:50:57 -0400 Subject: Re: [RFC PATCH 2/3] clocksource: mtk_timer: change pr_warn()s to pr_err()s in mtk_timer_init To: Alexey Klimov , daniel.lezcano@linaro.org, linux-mediatek@lists.infradead.org References: <1441336900-15095-1-git-send-email-alexey.klimov@linaro.org> <1441336900-15095-2-git-send-email-alexey.klimov@linaro.org> Cc: yingjoe.chen@mediatek.com, tglx@linutronix.de, linux-kernel@vger.kernel.org, klimov.linux@gmail.com From: Matthias Brugger Message-ID: <55E95B6F.4060506@gmail.com> Date: Fri, 4 Sep 2015 10:50:55 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <1441336900-15095-2-git-send-email-alexey.klimov@linaro.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/09/15 05:21, Alexey Klimov wrote: > These messages are actually errors and not warnings. > Use pr_err() macro for them and add missing \n. > > Signed-off-by: Alexey Klimov Acked-by: Matthias Brugger > --- > drivers/clocksource/mtk_timer.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/clocksource/mtk_timer.c b/drivers/clocksource/mtk_timer.c > index ca5ea9e..fbaacbf 100644 > --- a/drivers/clocksource/mtk_timer.c > +++ b/drivers/clocksource/mtk_timer.c > @@ -184,7 +184,7 @@ static void __init mtk_timer_init(struct device_node *node) > > evt = kzalloc(sizeof(*evt), GFP_KERNEL); > if (!evt) { > - pr_warn("Can't allocate mtk clock event driver struct"); > + pr_err("Can't allocate mtk clock event driver struct\n"); > return; > } > > @@ -200,24 +200,24 @@ static void __init mtk_timer_init(struct device_node *node) > > evt->gpt_base = of_io_request_and_map(node, 0, "mtk-timer"); > if (IS_ERR(evt->gpt_base)) { > - pr_warn("Can't get resource\n"); > + pr_err("Can't get resource\n"); > return; > } > > evt->dev.irq = irq_of_parse_and_map(node, 0); > if (evt->dev.irq <= 0) { > - pr_warn("Can't parse IRQ"); > + pr_err("Can't parse IRQ\n"); > goto err_mem; > } > > clk = of_clk_get(node, 0); > if (IS_ERR(clk)) { > - pr_warn("Can't get timer clock"); > + pr_err("Can't get timer clock\n"); > goto err_irq; > } > > if (clk_prepare_enable(clk)) { > - pr_warn("Can't prepare clock"); > + pr_err("Can't prepare clock\n"); > goto err_clk_put; > } > rate = clk_get_rate(clk); > @@ -226,7 +226,7 @@ static void __init mtk_timer_init(struct device_node *node) > > if (request_irq(evt->dev.irq, mtk_timer_interrupt, > IRQF_TIMER | IRQF_IRQPOLL, "mtk_timer", evt)) { > - pr_warn("failed to setup irq %d\n", evt->dev.irq); > + pr_err("failed to setup irq %d\n", evt->dev.irq); > goto err_clk_disable; > } > >