public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Peter Hurley <peter@hurleysoftware.com>
To: Vitaly Kuznetsov <vkuznets@redhat.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jiri Slaby <jslaby@suse.com>,
	linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
	"K. Y. Srinivasan" <kys@microsoft.com>,
	Dexuan Cui <decui@microsoft.com>
Subject: Re: [PATCH] serial: core: prevent softlockups on slow consoles
Date: Fri, 4 Sep 2015 06:42:26 -0400	[thread overview]
Message-ID: <55E97592.40307@hurleysoftware.com> (raw)
In-Reply-To: <87bndid52t.fsf@vitty.brq.redhat.com>

On 09/04/2015 03:19 AM, Vitaly Kuznetsov wrote:
> Greg Kroah-Hartman <gregkh@linuxfoundation.org> writes:

>> I don't like this, please narrow this down to the real problem that your
>> hardware has here, the putchar function should not be this slow.  If it
>> is, something is wrong.
> 
> I'm afraid this is really the case:
> 
> 3)               |                                          serial8250_console_putchar() {
> 3)               |                                            wait_for_xmitr() {
> 3) # 3111.189 us |                                              io_serial_in();
> 3) # 3115.334 us |                                            }
> 3) # 2234.099 us |                                            io_serial_out();
> 3) # 5353.883 us |                                          }
> 
> This is one char and I use local pipe for Hyper-V output. In case
> something like remote pipe is in use ...
> 
> So I'm sorry, but I don't really understand the suggestion to 'narrow
> this down' - this is how slow Hyper-V serial's implementation is,
> io_serial_in() is just an inb() and io_serial_out() is an outb().

That corresponds to 330-440 baud. As far as I'm concerned, that's broken.

Regards,
Peter Hurley


  reply	other threads:[~2015-09-04 10:42 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-31 14:34 [PATCH] serial: core: prevent softlockups on slow consoles Vitaly Kuznetsov
2015-09-02 14:38 ` Peter Hurley
2015-09-02 16:09   ` Vitaly Kuznetsov
2015-09-04  4:20 ` Greg Kroah-Hartman
2015-09-04  7:19   ` Vitaly Kuznetsov
2015-09-04 10:42     ` Peter Hurley [this message]
2015-09-04 16:10     ` Greg Kroah-Hartman
2015-09-06 11:48       ` Dexuan Cui
2015-09-06 11:58         ` KY Srinivasan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55E97592.40307@hurleysoftware.com \
    --to=peter@hurleysoftware.com \
    --cc=decui@microsoft.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jslaby@suse.com \
    --cc=kys@microsoft.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=vkuznets@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox