From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758323AbbIDLYZ (ORCPT ); Fri, 4 Sep 2015 07:24:25 -0400 Received: from mailout1.w1.samsung.com ([210.118.77.11]:50837 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752570AbbIDLYX (ORCPT ); Fri, 4 Sep 2015 07:24:23 -0400 X-AuditID: cbfec7f5-f794b6d000001495-c6-55e97f65873f Message-id: <55E97F64.3030904@samsung.com> Date: Fri, 04 Sep 2015 13:24:20 +0200 From: Jacek Anaszewski User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130804 Thunderbird/17.0.8 MIME-version: 1.0 To: Vaishali Thakkar Cc: Richard Purdie , linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] leds: leds-cobalt-qube: Use devm_led_classdev_register References: <20150901123525.GA12241@localhost> In-reply-to: <20150901123525.GA12241@localhost> Content-type: text/plain; charset=ISO-8859-1; format=flowed Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrALMWRmVeSWpSXmKPExsVy+t/xq7qp9S9DDSY18Fhc3jWHzWLrm3WM Frt3PWW1eL7yGqsDi8fOWXfZPfbM/8Hq8XmTXABzFJdNSmpOZllqkb5dAldGx4cW5oJlAhUT 1j1maWCcxNvFyMEhIWAi0dHv1MXICWSKSVy4t54NxBYSWMooseNLeBcjF5D9jFGi99J/FpAE r4CWRNvefrAiFgFViRuP5zKC2GwChhI/X7xmArFFBSIk/pzexwpRLyjxY/I9sF4RAV2JrxN/ gvUyCyRJPP56BKxXWMBP4v2lpYwg9wgJ6Ekc+W0EEuYU0JfYu3IPVLm1xMpJ2xghbHmJzWve Mk9gFJiFZMMsJGWzkJQtYGRexSiaWppcUJyUnmukV5yYW1yal66XnJ+7iRESrl93MC49ZnWI UYCDUYmH9+SPF6FCrIllxZW5hxglOJiVRHinBr4MFeJNSaysSi3Kjy8qzUktPsQozcGiJM47 c9f7ECGB9MSS1OzU1ILUIpgsEwenVAPjhlCP2bXfpzBw+mov4uw9rsLybcG1/2VPmDrd3k/N T+r3shOa1JQ47VFYF+tTZdaQm8GO6R/fPr6b/aTj3y6uwI0+B00CdjHUXfjJsD1NvrZrvsTs A7KG3y7fW9PROk/5utwnl9fBAkJsUSG12cVrdlYdYFoz97NlSIqs5ZWNXK2ZesuY1RSVWIoz Eg21mIuKEwGrw+B3UwIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Vaishali, On 09/01/2015 02:35 PM, Vaishali Thakkar wrote: > Use resource-managed function devm_led_classdev_register instead > of led_classdev_register to make the error-path simpler. > > To be compatible with the change, goto is replaced with direct > return, unneeded label err_null is dropped and unnecessary variable > retval is removed. Also, remove redundant cobalt_qube_led_remove. > > Signed-off-by: Vaishali Thakkar > --- > Changes since v1: > - Remove use of variable retval > - Change commit log > --- > drivers/leds/leds-cobalt-qube.c | 21 +-------------------- > 1 file changed, 1 insertion(+), 20 deletions(-) > > diff --git a/drivers/leds/leds-cobalt-qube.c b/drivers/leds/leds-cobalt-qube.c > index d975220..f1374d2 100644 > --- a/drivers/leds/leds-cobalt-qube.c > +++ b/drivers/leds/leds-cobalt-qube.c > @@ -36,7 +36,6 @@ static struct led_classdev qube_front_led = { > static int cobalt_qube_led_probe(struct platform_device *pdev) > { > struct resource *res; > - int retval; > > res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > if (!res) > @@ -49,31 +48,13 @@ static int cobalt_qube_led_probe(struct platform_device *pdev) > led_value = LED_FRONT_LEFT | LED_FRONT_RIGHT; > writeb(led_value, led_port); > > - retval = led_classdev_register(&pdev->dev, &qube_front_led); > - if (retval) > - goto err_null; > - > - return 0; > - > -err_null: > - led_port = NULL; > - > - return retval; > -} > - > -static int cobalt_qube_led_remove(struct platform_device *pdev) > -{ > - led_classdev_unregister(&qube_front_led); > - > - if (led_port) > - led_port = NULL; > + return devm_led_classdev_register(&pdev->dev, &qube_front_led); > > return 0; Merged, after removing stray "return 0", thanks. > } > > static struct platform_driver cobalt_qube_led_driver = { > .probe = cobalt_qube_led_probe, > - .remove = cobalt_qube_led_remove, > .driver = { > .name = "cobalt-qube-leds", > }, > -- Best Regards, Jacek Anaszewski