From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1760016AbbIDQSo (ORCPT <rfc822;w@1wt.eu>);
	Fri, 4 Sep 2015 12:18:44 -0400
Received: from mx2.suse.de ([195.135.220.15]:49322 "EHLO mx2.suse.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753532AbbIDQSn (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Fri, 4 Sep 2015 12:18:43 -0400
Subject: Re: [RESEND RFC v4 2/3] mm: make optimistic check for swapin
 readahead
To: Ebru Akagunduz <ebru.akagunduz@gmail.com>, linux-mm@kvack.org
References: <1441313508-4276-1-git-send-email-ebru.akagunduz@gmail.com>
 <1441313508-4276-3-git-send-email-ebru.akagunduz@gmail.com>
Cc: akpm@linux-foundation.org, kirill.shutemov@linux.intel.com,
        n-horiguchi@ah.jp.nec.com, aarcange@redhat.com, riel@redhat.com,
        iamjoonsoo.kim@lge.com, xiexiuqi@huawei.com, gorcunov@openvz.org,
        linux-kernel@vger.kernel.org, mgorman@suse.de, rientjes@google.com,
        aneesh.kumar@linux.vnet.ibm.com, hughd@google.com, hannes@cmpxchg.org,
        mhocko@suse.cz, boaz@plexistor.com, raindel@mellanox.com
From: Vlastimil Babka <vbabka@suse.cz>
Message-ID: <55E9C45F.60407@suse.cz>
Date: Fri, 4 Sep 2015 18:18:39 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.0.1
MIME-Version: 1.0
In-Reply-To: <1441313508-4276-3-git-send-email-ebru.akagunduz@gmail.com>
Content-Type: text/plain; charset=iso-8859-2
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 09/03/2015 10:51 PM, Ebru Akagunduz wrote:
> This patch introduces new sysfs integer knob
> /sys/kernel/mm/transparent_hugepage/khugepaged/max_ptes_swap
> which makes optimistic check for swapin readahead to
> increase thp collapse rate. Before getting swapped
> out pages to memory, checks them and allows up to a
> certain number. It also prints out using tracepoints
> amount of unmapped ptes.
> 
> Signed-off-by: Ebru Akagunduz <ebru.akagunduz@gmail.com>

...

>  #include <asm/pgalloc.h>
> @@ -49,7 +50,8 @@ static const char *const khugepaged_status_string[] = {
>  	"page_swap_cache",
>  	"could_not_delete_page_from_lru",
>  	"alloc_huge_page_fail",
> -	"ccgroup_charge_fail"
> +	"ccgroup_charge_fail",
> +	"exceed_swap_pte"
>  };
>  
>  enum scan_result {
> @@ -73,7 +75,8 @@ enum scan_result {
>  	SCAN_SWAP_CACHE_PAGE,
>  	SCAN_DEL_PAGE_LRU,
>  	SCAN_ALLOC_HUGE_PAGE_FAIL,
> -	SCAN_CGROUP_CHARGE_FAIL
> +	SCAN_CGROUP_CHARGE_FAIL,
> +	MM_EXCEED_SWAP_PTE

This one should be renamed too.