From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760470AbbIDUZE (ORCPT ); Fri, 4 Sep 2015 16:25:04 -0400 Received: from mail-lb0-f178.google.com ([209.85.217.178]:35545 "EHLO mail-lb0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759601AbbIDUZD (ORCPT ); Fri, 4 Sep 2015 16:25:03 -0400 Subject: Re: [PATCH] RDS: verify the underlying transport exists before creating a connection To: Sasha Levin , chien.yen@oracle.com, davem@davemloft.net References: <1441385019-27019-1-git-send-email-sasha.levin@oracle.com> Cc: rds-devel@oss.oracle.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org From: Sergei Shtylyov Organization: Cogent Embedded Message-ID: <55E9FE1A.4080103@cogentembedded.com> Date: Fri, 4 Sep 2015 23:24:58 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <1441385019-27019-1-git-send-email-sasha.levin@oracle.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello. On 09/04/2015 07:43 PM, Sasha Levin wrote: > There was no verification that an underlying transport exists when creating > a connection, this would cause dereferencing a NULL ptr. > > Signed-off-by: Sasha Levin > --- > net/rds/connection.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/net/rds/connection.c b/net/rds/connection.c > index a50e652..0218d81 100644 > --- a/net/rds/connection.c > +++ b/net/rds/connection.c > @@ -189,6 +189,12 @@ new_conn: > } > } > > + if (trans == NULL) { Please use !trans instead, it's the form preferred by the networking code. [...] MBR, Sergei