From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752397AbbIEM2R (ORCPT <rfc822;w@1wt.eu>);
	Sat, 5 Sep 2015 08:28:17 -0400
Received: from m50-138.163.com ([123.125.50.138]:53667 "EHLO m50-138.163.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751117AbbIEM2J (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Sat, 5 Sep 2015 08:28:09 -0400
Message-ID: <55EADE52.5010701@163.com>
Date: Sat, 05 Sep 2015 20:21:38 +0800
From: Wang Nan <pi3orama@163.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0
MIME-Version: 1.0
To: Namhyung Kim <namhyung@kernel.org>, Wang Nan <wangnan0@huawei.com>
CC: acme@redhat.com, mingo@kernel.org, ast@plumgrid.com,
        linux-kernel@vger.kernel.org, lizefan@huawei.com,
        Brendan Gregg <brendan.d.gregg@gmail.com>,
        Daniel Borkmann <daniel@iogearbox.net>,
        David Ahern <dsahern@gmail.com>, He Kuang <hekuang@huawei.com>,
        Jiri Olsa <jolsa@kernel.org>, Kaixu Xia <xiakaixu@huawei.com>,
        Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: [PATCH 18/31] perf test: Add 'perf test BPF'
References: <1440822125-52691-1-git-send-email-wangnan0@huawei.com> <1440822125-52691-19-git-send-email-wangnan0@huawei.com> <20150902124528.GA27663@danjae.kornet>
In-Reply-To: <20150902124528.GA27663@danjae.kornet>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
X-CM-TRANSID: C9GowAC3gyxS3upVROvgAQ--.49132S2
X-Coremail-Antispam: 1Uf129KBjvJXoW7ury8uF48uFWrZFykJFyDtrb_yoW8Zw4kpF
	Z5JF90yr1kurW29w1YqFW09a4avwsYgrW3XrsrGF10yr17ZrZ2gryxtrWjgFy8Aryakw4x
	ZrWUWFyIgw1kXrJanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2
	9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x07jutCwUUUUU=
X-Originating-IP: [210.73.4.168]
X-CM-SenderInfo: lslt02xdpdqiywtou0bp/xtbBdQVsQFEAONx6BAAAsX
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org



On 09/02/2015 08:45 PM, Namhyung Kim wrote:
> On Sat, Aug 29, 2015 at 04:21:52AM +0000, Wang Nan wrote:
>> This patch adds BPF testcase for testing BPF event filtering.
>>
>> By utilizing the result of 'perf test LLVM', this patch compiles the
>> eBPF sample program then test it ability. The BPF script in 'perf test
>> LLVM' collects half of execution of epoll_pwait(). This patch runs 111
>> times of it, so the resule should contains 56 samples.
>>
>> Signed-off-by: Wang Nan <wangnan0@huawei.com>
>> Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
>> Cc: Alexei Starovoitov <ast@plumgrid.com>
>> Cc: Brendan Gregg <brendan.d.gregg@gmail.com>
>> Cc: Daniel Borkmann <daniel@iogearbox.net>
>> Cc: David Ahern <dsahern@gmail.com>
>> Cc: He Kuang <hekuang@huawei.com>
>> Cc: Jiri Olsa <jolsa@kernel.org>
>> Cc: Kaixu Xia <xiakaixu@huawei.com>
>> Cc: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
>> Cc: Namhyung Kim <namhyung@kernel.org>
>> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
>> Cc: Zefan Li <lizefan@huawei.com>
>> Cc: pi3orama@163.com
>> Link: http://lkml.kernel.org/n/1440151770-129878-16-git-send-email-wangnan0@huawei.com
>> ---
>
> [SNIP]
>
>> +static int prepare_bpf(void *obj_buf, size_t obj_buf_sz)
>> +{
>> +	int err;
>> +	char errbuf[BUFSIZ];
>> +
>> +	err = bpf__prepare_load_buffer(obj_buf, obj_buf_sz, NULL);
>> +	if (err) {
>> +		bpf__strerror_prepare_load("[buffer]", false, err, errbuf,
>> +					   sizeof(errbuf));
>> +		fprintf(stderr, " (%s)", errbuf);
>> +		return TEST_FAIL;
>> +	}
>> +
>> +	err = bpf__probe();
>> +	if (err) {
>> +		bpf__strerror_load(err, errbuf, sizeof(errbuf));
>> +		fprintf(stderr, " (%s)", errbuf);
>> +		if (getuid() != 0)
>
> geteuid() ?
>
> Thanks,
> Namhyung
>

Already changed.

Thank you.

>
>> +			fprintf(stderr, " (try run as root)");
>> +		return TEST_FAIL;
>> +	}
>> +
>> +	err = bpf__load();
>> +	if (err) {
>> +		bpf__strerror_load(err, errbuf, sizeof(errbuf));
>> +		fprintf(stderr, " (%s)", errbuf);
>> +		return TEST_FAIL;
>> +	}
>> +
>> +	return 0;
>> +}